Support packing UDIM textures
Needs RevisionPublic
Actions

Authored by Lukas Stockner (lukasstockner97) on Dec 29 2019, 3:22 AM.

Details

Reviewers

Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Summary

This patch deduplicates quite a bit of stuff in image.c, otherwise the
additional complexity from tiles would have been a lot more.

The only thing that's not working yet is packed UDIMs in Cycles with OSL.

As far as I can tell everything works, but to be honest, I'm not very
familiar with how packed images are supposed to behave so some more
testing would probably be a good idea.

Diff Detail

Repository

rB Blender

Branch

udim_pack (branched from master)

Build Status

Buildable 6120
Build 6120: arc lint + arc unit

Event Timeline

Lukas Stockner (lukasstockner97) created this revision.Dec 29 2019, 3:22 AM

Harbormaster completed remote builds in B6120: Diff 20524.Dec 29 2019, 3:22 AM

Bartosz Moniewski (monio) added a subscriber: Bartosz Moniewski (monio).Dec 29 2019, 3:51 AM

Lukas Stockner (lukasstockner97) mentioned this in T72390: Improve UDIM functionality.Dec 29 2019, 4:35 PM

Please split refactor of image.c to a separate patch, so then it can also be applied separately. That helps reviewing and maintaining code when we know that there are no functional changes expected to happen.

intern/cycles/render/nodes.cpp
514	This `1001` should become a constant, in both Cycles and Blender side, with an explanation why this number is such special.

This revision now requires changes to proceed.Jan 2 2020, 3:24 PM

Philipp Oeser (lichtwerk) mentioned this in T73110: UDIM Texture Paint Crash.Jan 14 2020, 9:38 AM

dupoxy (dupoxy) added a subscriber: dupoxy (dupoxy).Feb 11 2020, 5:11 AM

Andreas Erni (Nihi) added a subscriber: Andreas Erni (Nihi).May 16 2020, 5:08 PM

Philipp Oeser (lichtwerk) mentioned this in T84854: Pack Tiled Image ( UDIM ) into .blend file is not supported.Jan 19 2021, 9:41 AM

silex (silex) awarded a token.Aug 23 2021, 4:57 PM

Asger Langhoff (Asger) added a subscriber: Asger Langhoff (Asger).Jan 3 2022, 1:02 PM

@Lukas Stockner (lukasstockner97) Hello, I've been working in the UDIM area the past few months and was wondering if it would be ok for me to try to tackle Packing support if that's ok with you?

In D6492#369516, @Jesse Yurkovich (deadpin) wrote:

@Lukas Stockner (lukasstockner97) Hello, I've been working in the UDIM area the past few months and was wondering if it would be ok for me to try to tackle Packing support if that's ok with you?

Yeah, sure, I'm not currently working on anything UDIM-related.

Andreas Erni (Nihi) removed a subscriber: Andreas Erni (Nihi).Jan 30 2022, 5:25 AM

Are there any news on this? Got burned a bit hard today on a major character release because I wasn't aware of this issue and we released Snow with not fully packed textures.
We also ran into the issue again while trying to pack the animation files.
This patch would save us a lot of headache when it comes to sharing stuff.

@Demeter Dzadik (Mets) I'm still working towards getting this in. It's been held up behind other code reviews and then bugs in neighboring areas all of Feb. I should be starting work back up for this very soon.

Jesse Yurkovich (deadpin) mentioned this in D14327: Cleanup: Reduce duplication to prepare for UDIM packing.Mar 14 2022, 3:24 AM

Demeter Dzadik (Mets) awarded a token.Mar 14 2022, 5:03 PM

Jesse Yurkovich (deadpin) mentioned this in rB77155ae1c03e: Cleanup: Reduce duplication to prepare for UDIM packing.Mar 28 2022, 3:14 AM

Grigory To (lampy) added a subscriber: Grigory To (lampy).Mar 28 2022, 7:16 PM

Daniel Salazar (zanqdo) awarded a token.Apr 25 2022, 9:24 PM