Page MenuHome

Fix T54395 - Sequencer Original Dimensions shows Proxy Dimensions
ClosedPublic

Authored by Eitan Traurig (EitanSomething) on Jan 1 2020, 5:51 AM.

Details

Summary

Fixes the Original Dimensions showing Proxy Dimensions for Movie strip by loading dimensions into strip->stripdata->orig_width and orig_height when the file is added and not every time a new frame is loaded

Diff Detail

Repository
rB Blender

Event Timeline

Eitan Traurig (EitanSomething) retitled this revision from Fix Original Dimensions shows Proxy Dimensions for Movie strip to Fix T54395 - Sequencer Original Dimensions shows Proxy Dimensions.Jan 1 2020, 5:52 AM

@Eitan Traurig (EitanSomething)

TODO load the original file dimensions for image files. @Richard Antalik (ISS) what would be the best way to do this?

It could be same as with movie - assign on first load and when path is changed(via operator, API or any legitimate way).
Not sure now, if there isn't different resolution for every frame in image strips, and if there is some function to get resolution without rendering image itself.

We should be careful if we want to rely on this value (for example to resolve T51828).

We should be careful if we want to rely on this value (for example to resolve T51828).

I don't see a problem relying on this value to resolve T51828

  • Update to master
  • Set orig_width and orig_height when adding new movie or image
This revision is now accepted and ready to land.Mar 16 2021, 1:43 AM
Richard Antalik (ISS) requested changes to this revision.Mar 16 2021, 1:48 AM

Oops, found issue here:
When you add image sequence, this will cause source resolution to be None when you are anywhere in strip.
it will work well only for first image. so this would be best to either initialize all images to same value, or change UI to show value of first image only.

This revision now requires changes to proceed.Mar 16 2021, 1:48 AM

Oops, found issue here:
When you add image sequence, this will cause source resolution to be None when you are anywhere in strip.
it will work well only for first image. so this would be best to either initialize all images to same value, or change UI to show value of first image only.

I am unable to reproduce this can you send me a blend file

Oops, found issue here:
When you add image sequence, this will cause source resolution to be None when you are anywhere in strip.
it will work well only for first image. so this would be best to either initialize all images to same value, or change UI to show value of first image only.

I am unable to reproduce this can you send me a blend file

Sure, here is example file:

Add image sequence like it is in this file and go to middle of strip. Source resolution will say "None". All frames are black but this is sequence of multiple images. probably not best example, let me know if you need better one.

One thing I would add is, that it would be probably best if this size could be updated during preview for case it doesn't match. This could fix old files that would be otherwise stuck in incorrect state. Not best solution, but probably only good solution right now.

Oops, found issue here:
When you add image sequence, this will cause source resolution to be None when you are anywhere in strip.
it will work well only for first image. so this would be best to either initialize all images to same value, or change UI to show value of first image only.

I am unable to reproduce this can you send me a blend file

Sure, here is example file:

Add image sequence like it is in this file and go to middle of strip. Source resolution will say "None". All frames are black but this is sequence of multiple images. probably not best example, let me know if you need better one.

One thing I would add is, that it would be probably best if this size could be updated during preview for case it doesn't match. This could fix old files that would be otherwise stuck in incorrect state. Not best solution, but probably only good solution right now.

I think you are going to have to fix the bug because I am still unable to reproduce it.

I think you are going to have to fix the bug because I am still unable to reproduce it.

Will do this one right away, otherwise chances are that I would never get to it...

  • Update image size when rendering non-proxy image, set image size for all images in sequence
This revision is now accepted and ready to land.Mar 17 2021, 7:57 PM