Sculpt: Fix when using Shift+LMB shortcut and operator can't find the target brush
Needs ReviewPublic
Actions

Authored by Juanfran Matheu (jfmatheu) on Jan 2 2020, 12:32 PM.

Details

Reviewers

Pablo Dobarro (pablodp606)

Summary

The Issue:

When shift+left mouse shortcut is used in sculpt (or any other configured using 'sculpt.brush_stroke') and

sculpt_update_cache_invariants

can't find the brush by the name (the name of the target brush has been changed eg. "Smooth" brush is now called "Smoother") :

You are unable to use the smooth brush
The radius is set to 1px causing an annoying effect for users

EXAMPLE:

This patch fixes all this when user renames the target brush that is specified in code.

Diff Detail

Event Timeline

Juanfran Matheu (jfmatheu) created this revision.Jan 2 2020, 12:32 PM

Now it searches for an alternative smooth brush when "Smooth" brush isn't available or is renamed.

Juanfran Matheu (jfmatheu) edited the summary of this revision. (Show Details)Jan 2 2020, 1:59 PM

Metin Seven (MetinSeven) awarded a token.Jan 2 2020, 2:22 PM

Juanfran Matheu (jfmatheu) retitled this revision from Sculpt: Fix radius set to 1 when using 'sculpt.brush_stroke' operator and can't find the target brush to Sculpt: Fix when using 'sculpt.brush_stroke' operator and can't find the target brush.Jan 2 2020, 2:41 PM

Juanfran Matheu (jfmatheu) retitled this revision from Sculpt: Fix when using 'sculpt.brush_stroke' operator and can't find the target brush to Sculpt: Fix when using Shift+LMB shortcut and operator can't find the target brush.

Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).Jan 2 2020, 3:46 PM

Antonio Vazquez (antoniov) added inline comments.