Fix T68878: Update shapekeys during transformation
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Jan 3 2020, 2:52 AM.

Details

Reviewers

Brecht Van Lommel (brecht)

Group Reviewers

Modifiers

Maniphest Tasks

T68878: Shape Keys do not update properly

Commits

rBbde215a60c16: Fix T68878: Update shapekeys during transformation

Summary

This fixes T68878

As shown in the report, during edit mode, when you have more than one
shapekey and you have the Shape Key Edit Mode option enabled, changes
to the Base Key don't result in any changes to the displayed mesh.

This patch proposes to use the hack in key_block_get_data just for
the bmesh shapekey.
The remaining shapekeys use the original offset values.

Diff Detail

Repository: rB Blender

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Jan 3 2020, 2:52 AM

Harbormaster completed remote builds in B6155: Diff 20609.Jan 3 2020, 2:52 AM

Germano Cavalcante (mano-wii) mentioned this in D6514: WIP: Update shapekeys during transformation.Jan 3 2020, 2:54 AM

Fix problem generated by previous solution

Harbormaster completed remote builds in B6160: Diff 20616.Jan 3 2020, 5:50 PM

Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)Jan 3 2020, 5:54 PM

Cleanup
Rebase

Harbormaster completed remote builds in B6675: Diff 21848.Feb 18 2020, 4:48 PM

Germano Cavalcante (mano-wii) edited reviewers, added: Modifiers; removed: Campbell Barton (campbellbarton).Feb 18 2020, 4:49 PM

Brecht Van Lommel (brecht) accepted this revision as: Brecht Van Lommel (brecht).Feb 19 2020, 12:42 AM

This revision is now accepted and ready to land.Feb 19 2020, 12:42 AM

Closed by commit rBbde215a60c16: Fix T68878: Update shapekeys during transformation (authored by Germano Cavalcante (mano-wii)). · Explain WhyFeb 19 2020, 12:54 PM

This revision was automatically updated to reflect the committed changes.

Germano Cavalcante (mano-wii) added a commit: rBbde215a60c16: Fix T68878: Update shapekeys during transformation.

Philipp Oeser (lichtwerk) mentioned this in T76715: exporting animated shapekeys as triangulated .OBJ files with default exporter cause invalid mesh result .May 14 2020, 4:21 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

key.c

13 lines

Diff 21880

View Options

source/blender/blenkernel/intern/key.c

Fix T68878: Update shapekeys during transformationClosedPublicActions