Differential D6520
Fix T72119: UV/Image Editor theme's face colors Authored by Eitan Traurig (EitanSomething) on Jan 3 2020, 5:33 PM.
Details
The in int flag; in gpu_shader_2D_edituvs_faces_vert.glsl don't have the values FACE_UV_ACTIVE and FACE_UV_SELECT. This patch indicates where it could be added. But this logic is also seen in mesh_render_data_face_flag so we need to evaluate if there is something being duplicated. Ref T72119
Diff Detail
Event TimelineComment Actions Just a minor code style.
Comment Actions After analyzing the code better, it seems that mesh_render_data_loop_flag is a generic function and must be followed by one of the: mesh_render_data_loop_edge_flag or mesh_render_data_face_flag to configure as requested. Comment Actions Well it seems that is not the case. But to deduplicate the code we could set all flags on the face (even those not needed): diff --git a/source/blender/draw/intern/draw_cache_extract_mesh.c b/source/blender/draw/intern/draw_cache_extract_mesh.c index cce1710423b..43eb6f17da0 100644 --- a/source/blender/draw/intern/draw_cache_extract_mesh.c +++ b/source/blender/draw/intern/draw_cache_extract_mesh.c @@ -2670,6 +2670,7 @@ static void extract_edituv_data_loop_bmesh(const MeshRenderData *mr, EditLoopData *eldata = data->vbo_data + l; memset(eldata, 0x0, sizeof(*eldata)); mesh_render_data_loop_flag(mr, loop, data->cd_ofs, eldata); + mesh_render_data_face_flag(mr, loop->f, data->cd_ofs, eldata); mesh_render_data_loop_edge_flag(mr, loop, data->cd_ofs, eldata); } I think it would be better this way. But I don't have a strong opinion. diff edited:
| ||||||||||||||