T68649 Improve communication of auto-save behavior by adding dialog box to "Load Factory Preferences".
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
It's nice to have a standard dialog for that.
I just hope that the Windows version of that dialog will have the Cancel button on the right side. 😉
Comment Actions
This is a nice improvement. Feel free to set your preferred color for that icon in the theme (BKE_blender_version.h and versioning_userdef.c).
Wondering though if you can use the extra space afforded here to simplify this process a bit.
Just a quick (and less than ideal) thought: Since this is in response to the user selecting "Load Factory Settings", the main title question of the dialog could be "Load and SAVE Factory Preferences?" Then the explanatory text could say something like "Answering 'Yes' will load and save Preferences, while 'No' will load the preferences but not save them. Select "Cancel" to do nothing.
[Yes] [No] [Cancel]
With "Yes" as default button.
The sample text above is obviously a bit crap, but something like it (but better) might cover all the possibilities nicely and would guide the user through choices that can be a bit confusing right now.
Another (probably dumb) thought is to break with this format a bit and change the buttons so that they are each the full width of the right-side content area. Then the first (wide) button could say "Load Factory Settings", the second could say "Load and SAVE Factory Settings", and the third would be "Cancel"
Comment Actions
Since this has a bit higher stakes than regular "confirm" popups it's nice for it to be special. Just a few comments on wording and such.
| source/blender/windowmanager/intern/wm_files.c | ||
|---|---|---|
| 2089 | This should take into account rBbdad412fa76e6f so the dialog is wide enough with any text size setting. | |
| 2129 | I would suggest something more like: "Preferences will not be saved when quitting after loading factory settings." | |
| 2134 | Here I would suggest "Use \"Save Startup File\" and \"Save Preferences\" to make permanent changes to preferences." | |
| 2143 | What about using the warning icon here? I think that's more common, I've never seen "WARNING" in Blender before. | |
Comment Actions
Mostly fine. Nice change!
I think it's good to have a consistent dialog that always shows up when you're closing the current file at the risk of data loss. That helps users spotting these cases.
| source/blender/windowmanager/intern/wm_files.c | ||
|---|---|---|
| 2032 | This static variable is easy to avoid I think. Just pass it as arg to UI_popup_block_invoke(), to the functions that need it, and via arg2 in UI_but_func_set() to the buttons that need it. You should use POINTER_FROM_INT()/POINTER_AS_INT() for that. | |
| 2179 | I know this follows existing code, but I'd prefer logic to not depend on operator names. | |
Comment Actions
What about using the warning icon here? I think that's more common, I've never seen "WARNING" in Blender before.
We may not use "WARNING" but two icons do not look good.
Comment Actions
Looks good to me now. Although there's one thing that confuses me.
| source/blender/windowmanager/intern/wm_files.c | ||
|---|---|---|
| 1959 | Where is this function coming from? I can't find it in master. | |
Comment Actions
@Julian Eisel (Severin) Would it be possible to check on this patch again for Blender 3.1? Thanks in advance!