Differential D6536
Fix T72900: Unneeded Redraws when gizmos are hidden in 3d viewport Authored by Jeroen Bakker (jbakker) on Jan 6 2020, 4:52 PM.
Details When 3d viewport has gizmos hidden, the gizmos refresh states won't be reset, There are other ways how to solve this, but as the reset is very small I
Diff Detail
Event TimelineComment Actions There is no ideal place to solve this issue, without doing more refactoring. As gizmo's and wm are closer to each other I propose the current patch. Comment Actions Wanted to mention it here but this patch doesn't seem to fix a similar, perhaps related(?), issue: Extra viewport redraws happen if you have Gizmos visible, and you just mouse over them. Mousing over the gizmo, which highlights it a bit, causes the entire viewport to re-render which makes them quite unusable to have enabled, in rendered view at least. Do you want a separate bug for this? Or do you want to attempt to address here if it's sufficiently related? Comment Actions Hi @Jesse Yurkovich (deadpin), would be ok to add a separate report at least. There has been a change to the gizmos that introduces these issues, we need to rethink if that implementation is mature enough. Can you mention this ticket/patch in your report. Comment Actions @Jeroen Bakker (jbakker) thanks for looking into this. While I wanted to avoid adding gizmo logic into gestures, in this case the chance of a feedback loop is too high. |