Fix T71154: EEVEE Soft Shadows Viewport Rendering
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Jan 7 2020, 9:22 AM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T71154: New soft shadows don't support viewport render [no TAA]

Commits

rB7c9d15fca876: Fix T71154: EEVEE Soft Shadows Viewport Rendering

Summary

EEVEE Soft shadows were not rendered correctly during viewport
rendering. The reason for this is that during viewport rendering the
shadow buffers were only update once and not per sample. This resulted
that all the samples calculated the same shadow.

This fix moves the call to EEVEE_shadows_update from cache finished to
draw scene.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Jan 7 2020, 9:22 AM

Harbormaster completed remote builds in B6178: Diff 20652.Jan 7 2020, 9:22 AM

Mikhail Rodionov (MARodionov) awarded a token.Jan 7 2020, 11:41 PM

Matej Junk (MJunk) awarded a token.Jan 8 2020, 7:37 AM

where i can download this fork to build it myself? i really need this stuff for my animation project.

In D6538#154059, @Mikhail Rodionov (MARodionov) wrote:

where i can download this fork to build it myself? i really need this stuff for my animation project.

You have to compile it yourself. Just apply this patch to the codebase and you can use it.
We are looking into making this a download button in the patch but that needs additional infrastructure to be setup.

In D6538#154063, @Jeroen Bakker (jbakker) wrote:

In D6538#154059, @Mikhail Rodionov (MARodionov) wrote:

where i can download this fork to build it myself? i really need this stuff for my animation project.

You have to compile it yourself. Just apply this patch to the codebase and you can use it.
We are looking into making this a download button in the patch but that needs additional infrastructure to be setu

In D6538#154063, @Jeroen Bakker (jbakker) wrote:

In D6538#154059, @Mikhail Rodionov (MARodionov) wrote:

where i can download this fork to build it myself? i really need this stuff for my animation project.

You have to compile it yourself. Just apply this patch to the codebase and you can use it.
We are looking into making this a download button in the patch but that needs additional infrastructure to be setup.

Thank you very much, compiled (2.81 branch) and it works, it is not as stable as official build and crashes when switching between cameras by markers but viewport rendering works and that means that i'll be able to render my project in time!
I hope that this fix will be in 2.82 release - it will make blender a renderfarm killer... 20 frames per min...

Evan Wilson (EAW) awarded a token.Jan 12 2020, 3:13 PM

Is there a way to have this fix in 2.82? Pleeease....
https://drive.google.com/file/d/1m-vOFkt-00y_iFumboZWjT3cJPWvoT7S/view?usp=sharing - i rendered it all for 1 night - 8 hours with this fix, and by F12 it was about 6 days before...