Page MenuHome

Compositor: Exposure Node
AbandonedPublic

Authored by Aaron Carlisle (Blendify) on Jan 7 2020, 9:41 PM.

Details

Summary

This new node increases the radiance of an image by a scalar value.

This can optionally affect the alpha channel which makes the node work
similar to the "Multiply" option in the sequencer.

This is in hopes of removing the brightness node which additive which causes colors to get washed out:

Both images have the same white value.

Diff Detail

Event Timeline

Init node to not use alpha by default

Aaron Carlisle (Blendify) edited the summary of this revision. (Show Details)
Jeroen Bakker (jbakker) requested changes to this revision.Jan 8 2020, 4:11 PM
Jeroen Bakker (jbakker) added inline comments.
source/blender/compositor/nodes/COM_ExposureNode.cpp
33 ↗(On Diff #20675)

Do not use a number. You can use an enum for this.

source/blender/compositor/operations/COM_ExposureOperation.h
23 ↗(On Diff #20675)

Perhaps also for this operation create a second variation with a constant exposure and use that when the input socket isn't connected isLinked.

This revision now requires changes to proceed.Jan 8 2020, 4:11 PM

The idea of D6546 and D6544 is to replace the current bright/contrast node. Before I get into fixing these patches how would this work as far as compatibility? The compatibility will likely be broken, the old node should be removed, it is broken and unfunctional and leaving it in the UI will confuse users.

As mentioned in D6546: Compositing: New Contrast Node, don't add a new node for this.

Also leave out the use_alpha option, multiplying alpha with exposure makes no sense.

Expand current bright contrast node

The one issue I have with keeping this with the existing node is UI discoverability.

Brecht Van Lommel (brecht) requested changes to this revision.Apr 28 2020, 10:51 AM

I don't mind renaming this node to e.g. Exposure - Contrast if that helps discoverability.

Please add an enum to switch between the new and legacy algorithm, with default to new. Mixing old and new logic makes little sense to me.

This revision now requires changes to proceed.Apr 28 2020, 10:51 AM

This patch does not need an enum as it only adds a new parameter at its default value this node matches the old node. Its my other patch that would require an enum.

Great stuff, was looking for an exposure node today. Hope this gets added soon!

Solved it like this which I think is correct?

I decided to make a new node rather than add to the bright/contrast node see D9677 for an updated patch.