Page MenuHome
Differential D6547

Fix T72235: crash entering particle editmode with non-valid PTCacheEdit psys pointer
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jan 8 2020, 1:12 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Sebastián Barschkis (sebbas)
Maniphest Tasks
T59583: Hair Dynamics: entering particle edit mode with baked cache crashes blender
T72235: Crash when trying to enter in "Particle Edit" mode of an object with Cloth physics and baked cloth data
Commits
rB75f82d28e38f: Fix T72235: crash entering particle editmode with non-valid PTCacheEdit psys…
Summary

Caused by own rBe02ecd599bdc.
Can happen with e.g. cloth.

Also fixes T59583

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Jan 8 2020, 1:12 PM
Harbormaster completed remote builds in B6197: Diff 20686.Jan 8 2020, 1:12 PM
Jacques Lucke (JacquesLucke) accepted this revision.Jan 8 2020, 1:22 PM

All these if (edit->psys) are annoying ^^
But I guess we can't just early return here.. so it's fine.

This revision is now accepted and ready to land.Jan 8 2020, 1:22 PM
Closed by commit rB75f82d28e38f: Fix T72235: crash entering particle editmode with non-valid PTCacheEdit psys… (authored by Philipp Oeser (lichtwerk)). · Explain WhyJan 8 2020, 1:39 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB75f82d28e38f: Fix T72235: crash entering particle editmode with non-valid PTCacheEdit psys….

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
physics/
2 lines

Diff 20690

View Options

source/blender/editors/physics/particle_edit.c

Loading...