rB4cde92303f3d made a MESH-only check (but that is no longer mandatory since the Mesh is fetched by MOD_deform_mesh_eval_get instead of ctx->object->data now...).
This would fail for projecting beveled curves (resulting mesh missing), now also get the mesh for curves if we use MOD_SHRINKWRAP_PROJECT (and only then).
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- T68489 (branched from master)
- Build Status
Buildable 6199 Build 6199: arc lint + arc unit
Event Timeline
| source/blender/modifiers/intern/MOD_shrinkwrap.c | ||
|---|---|---|
| 111–112 | Do we really still need this check? | |
| source/blender/modifiers/intern/MOD_shrinkwrap.c | ||
|---|---|---|
| 111–112 | I would say no, but since there is also rB15add11595fc: MOD_shrinkwrap: do not compute mesh when not needed., I'll tweak the patch so it only gets the mesh from curves when in MOD_SHRINKWRAP_PROJECT mode. | |
Comment Actions
It got better.
If the check is to avoid unnecessary mesh computation, I think it would be good to inform in the comment.
Comment Actions
Besides comment below, LGTM.
| source/blender/modifiers/intern/MOD_shrinkwrap.c | ||
|---|---|---|
| 111–112 | Think the first check should also include OB_LATTICE object type? Lattices also have vgroups, and support that modifier… | |