UI: Fix the small stretching of the splash screen block
ClosedPublic
Actions

Authored by Yevgeny Makarov (jenkm) on Jan 8 2020, 2:16 PM.

Details

Reviewers

William Reynish (billreynish)
Brecht Van Lommel (brecht)
Julian Eisel (Severin)

Commits

rBbdf260a1b8f8: UI: Avoid manual right-alignment of text in splash screen

Summary

Fixed small stretching of the splash screen block caused by wrong labels width/position.

~~The splash screen image must have a radius of rounding corners equal to 8px or less (for default theme with roundness of 0.4).~~
See D6847 for programmatic corners rounding.

Diff Detail

Repository: rB Blender

Event Timeline

Yevgeny Makarov (jenkm) created this revision.Jan 8 2020, 2:16 PM

It is also very strange to use an image with a width of 501 pixels, rather than exactly 500 pixels.

And the /release/datafiles/splash_template.xcf was last updated in 2016.

William Reynish (billreynish) accepted this revision as: William Reynish (billreynish).Jan 8 2020, 7:13 PM

This revision is now accepted and ready to land.Jan 8 2020, 7:13 PM

Yevgeny Makarov (jenkm) retitled this revision from UI: small fixes for splash screen to UI: Fix the small stretching of the splash screen block.Feb 14 2020, 10:37 AM

Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)

Yevgeny Makarov (jenkm) edited reviewers, added: Brecht Van Lommel (brecht); removed: User Interface.

Yevgeny Makarov (jenkm) mentioned this in D6847: UI: Rounding the corners of the splash image according to the theme preferences..Feb 14 2020, 4:29 PM

Yevgeny Makarov (jenkm) updated this revision to Diff 22885.Mar 17 2020, 8:21 PM

Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)

William Reynish (billreynish) awarded a token.Mar 17 2020, 9:56 PM

Yevgeny Makarov (jenkm) added a reviewer: Julian Eisel (Severin).Apr 6 2020, 7:39 PM

The 1 pixel size change shouldn't be needed anymore with D6999. The label change seems fine though, I will commit that tomorrow.

Closed by commit rBbdf260a1b8f8: UI: Avoid manual right-alignment of text in splash screen (authored by Yevgeny Makarov (jenkm), committed by Julian Eisel (Severin)). · Explain WhyApr 15 2020, 11:51 AM

This revision was automatically updated to reflect the committed changes.

Julian Eisel (Severin) added a commit: rBbdf260a1b8f8: UI: Avoid manual right-alignment of text in splash screen.

Pablo Vazquez (pablovazquez) awarded a token.Apr 17 2020, 2:21 PM