This forces the full geometry when that overlay is enabled.
I would rather not support this and leave that bug as a know issues/
limitation because this is terrible for performance and people may not
be aware that by enabling the option they are disabling the
optimization.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
That is a heavy operation, would the reverse not be better (when in sculpt mode draw the face orientation overlay with the sculpt mesh).
Comment Actions
- Use sculpt mesh to draw the facing overlay
I'm not sure if this is the correct way of doing it of it we need more checks to avoid other bugs.
Comment Actions
Yes there might be more overlays not working with sculpt drawing but I cannot think of any at this moment. I would say to wait for actual reports to see where we need them.
| source/blender/draw/engines/overlay/overlay_facing.c | ||
|---|---|---|
| 49–59 | we normally do const DRWContextState *draw_ctx = DRW_context_state_get();
const bool use_sculpt_pbvh = BKE_sculptsession_use_pbvh_draw(ob, draw_ctx->v3d) &&
!DRW_state_is_image_render();
if (use_sculpt_pbvh) {This also checks for modifiers and shading | |