Paths

Table of Contentst

Differential D6557

Cycles: Fix viewport rendering when displaying as byte and not half float
ClosedPublic
Actions

Authored by Patrick Mours (pmoursnv) on Jan 10 2020, 3:06 PM.

Tags

None

Subscribers

None

Details

Reviewers

Jeroen Bakker (jbakker)
Brecht Van Lommel (brecht)

Commits

rCec581eee5db2: Fix viewport rendering when displaying as byte and not half float
rB1cb938ef2c92: Cycles: Fix viewport rendering when displaying as byte and not half float

Summary

Commit rB7e61e597253f3ca75f2fb86a57212ca750ffbbe8 broke viewport rendering when not displaying as halfs. This is because it was forgotten to actually use the scale parameter that is passed into film_map. This fixes that, and also de-duplicates code around it.

Bug can be reproduced by building Blender without WITH_OPENCOLORIO, which switches viewport rendering to bytes.

Diff Detail

Repository: rB Blender

Event Timeline

Patrick Mours (pmoursnv) created this revision.Jan 10 2020, 3:06 PM

Harbormaster completed remote builds in B6210: Diff 20710.Jan 10 2020, 3:06 PM

Brecht Van Lommel (brecht) accepted this revision.Jan 10 2020, 4:05 PM

This revision is now accepted and ready to land.Jan 10 2020, 4:05 PM

Closed by commit rB1cb938ef2c92: Cycles: Fix viewport rendering when displaying as byte and not half float (authored by Patrick Mours (pmoursnv)). · Explain WhyJan 10 2020, 4:31 PM

This revision was automatically updated to reflect the committed changes.

Patrick Mours (pmoursnv) added a commit: rB1cb938ef2c92: Cycles: Fix viewport rendering when displaying as byte and not half float.

Nathan Letwory (jesterking) added a commit: rCec581eee5db2: Fix viewport rendering when displaying as byte and not half float.Jan 13 2020, 11:33 PM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

kernel/

33 lines

Diff 20712

intern/cycles/kernel/kernel_film.h

Loading...