Page MenuHome
Differential D6570

Fix T72648: Texture Paint color sampling always samples only 1st tile when using UDIMS
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jan 13 2020, 3:12 PM.

Details

Reviewers
Lukas Stockner (lukasstockner97)
Jeroen Bakker (jbakker)
Maniphest Tasks
T72648: 2.82 Texture Paint/UDIM - color sampling always samples only 1st tile when using UDIMS
Commits
rB75100d0b943b: Fix T72648: Texture Paint color sampling always samples only 1st tile when…
Summary

A more generic approach might be considered (I assume there are other
operators around that need an update in shifting their uvs), this is
just to have this bug fixed.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Jan 13 2020, 3:12 PM
Harbormaster completed remote builds in B6226: Diff 20749.Jan 13 2020, 3:12 PM
Lukas Stockner (lukasstockner97) requested changes to this revision.Jan 13 2020, 3:52 PM

Mostly fine, just one comment. Also, yeah, this is the correct approach so far, we might consider adding a helper function (something like BKE_image_acquire_ibuf_from_uv(Image* ima, ImageUser* iuser, float* uv)) at some point though.

source/blender/editors/sculpt_paint/paint_utils.c
525

Please use BKE_imageuser_default to initialize the ImageUser instead of zeroing it.

This revision now requires changes to proceed.Jan 13 2020, 3:52 PM
Philipp Oeser (lichtwerk) updated this revision to Diff 20753.Jan 13 2020, 4:02 PM

use BKE_imageuser_default to initialize the ImageUser

Harbormaster completed remote builds in B6229: Diff 20753.Jan 13 2020, 4:02 PM
Lukas Stockner (lukasstockner97) accepted this revision.Jan 14 2020, 12:32 AM
This revision is now accepted and ready to land.Jan 14 2020, 12:32 AM
Closed by commit rB75100d0b943b: Fix T72648: Texture Paint color sampling always samples only 1st tile when… (authored by Philipp Oeser (lichtwerk)). · Explain WhyJan 15 2020, 9:45 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB75100d0b943b: Fix T72648: Texture Paint color sampling always samples only 1st tile when….

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sculpt_paint/
26 lines

Diff 20852

View Options

source/blender/editors/sculpt_paint/paint_utils.c

Loading...