Page MenuHome
Differential D6583

In object_hide_view_set_exec only hide objects if their collection is visible
ClosedPublic
Actions

Authored by Robert Guetzkow (rjg) on Jan 14 2020, 10:22 PM.

Details

Reviewers
Dalai Felinto (dfelinto)
Commits
rB0e94d8bbe09e: Fix T72302: Only hide objects if their collection is visible
Summary

In Blender 2.80 Shift + H (object_hide_view_set(unselected=True)) used to (temporarily) hide objects only if their collection was visible in the current view layer. This behavior was changed in rB0812949bbc3d7acfd1f20a47087ff973110aa177 (D5992) by using BASE_VISIBLE_DEPSGRAPH for the decision which object's (temporary) visibility should remain unchanged. Since the view layer visibility and depsgraph visibility has been decoupled in said commit, the correct condition to check is BASE_VISIBLE_VIEWLAYER.

This patch is a fix for T72302

Diff Detail

Repository
rB Blender

Event Timeline

Robert Guetzkow (rjg) created this revision.Jan 14 2020, 10:22 PM
Harbormaster completed remote builds in B6249: Diff 20846.Jan 14 2020, 10:22 PM
Robert Guetzkow (rjg) edited the summary of this revision. (Show Details)Jan 14 2020, 10:23 PM
Dalai Felinto (dfelinto) accepted this revision.Jan 15 2020, 12:09 PM
This revision is now accepted and ready to land.Jan 15 2020, 12:09 PM
Closed by commit rB0e94d8bbe09e: Fix T72302: Only hide objects if their collection is visible (authored by Robert Guetzkow (rjg), committed by Dalai Felinto (dfelinto)). · Explain WhyJan 15 2020, 1:08 PM
This revision was automatically updated to reflect the committed changes.
Dalai Felinto (dfelinto) added a commit: rB0e94d8bbe09e: Fix T72302: Only hide objects if their collection is visible.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
object/
2 lines

Diff 20858

View Options

source/blender/editors/object/object_edit.c

Loading...