Sculpt: Crease brush: Pinch perpendicular and new defaults
AbandonedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Jan 15 2020, 4:13 PM.

Details

Reviewers

Julien Kaspar (JulienKaspar)
Jeroen Bakker (jbakker)

Summary

This patch adds the same code to pinch only in the direction perpendicular to the stroke that is in D6587 to the crease brush.
I also updated the defaults to have something that matches better this new behavior.

Diff Detail

Repository

rB Blender

Branch

brush-perpendicular-falloff (branched from master)

Build Status

Buildable 6692
Build 6692: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Jan 15 2020, 4:13 PM

Harbormaster completed remote builds in B6260: Diff 20864.Jan 15 2020, 4:13 PM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Jan 15 2020, 4:14 PM

Pablo Dobarro (pablodp606) added a reviewer: Julien Kaspar (JulienKaspar).

Fix Blob Brush

Harbormaster completed remote builds in B6261: Diff 20865.Jan 15 2020, 4:33 PM

Pablo Dobarro (pablodp606) mentioned this in D6587: Sculpt: Pinch only in the direction perpendicular to the stroke.Jan 15 2020, 4:36 PM

Silas Opel (Schamph) awarded a token.Jan 24 2020, 5:06 PM

Rebase
Review update

Harbormaster completed remote builds in B6692: Diff 21894.Feb 19 2020, 6:51 PM

@Jeroen Bakker (jbakker) I applied the same changes of the revision in D6587 to this patch. The code is the same.

Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).Feb 19 2020, 6:52 PM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Feb 19 2020, 7:22 PM

Konstantina Anagnostou (Constantina32) added a subscriber: Konstantina Anagnostou (Constantina32).Feb 19 2020, 7:55 PM

Brandon (Brandon777) awarded a token.Feb 19 2020, 10:23 PM

Overall looks good to me, just some small code style remarks.

source/blender/editors/sculpt_paint/sculpt.c
2905	This seems like that this functions has been moved. I didn't see any code differences. Is this OK?
3455	Bit of a code style question. Is it useful to duplicate this code. I can imagine it is.