Page MenuHome
Differential D6592

UI: Rearrange Keymap Preferences
ClosedPublic
Actions

Authored by Yevgeny Makarov (jenkm) on Jan 15 2020, 5:31 PM.

Details

Reviewers
William Reynish (billreynish)
Commits
rBbada2dcafd98: UI: improve layout of keymap preferences, more consistent with other areas
Summary

Rearrange (match up with others) keymap preferences, change some labels.

Diff Detail

Repository
rB Blender

Event Timeline

Yevgeny Makarov (jenkm) created this revision.Jan 15 2020, 5:31 PM
noki paike (amonpaike) awarded a token.Jan 15 2020, 11:49 PM
noki paike (amonpaike) added a subscriber: noki paike (amonpaike).Jan 15 2020, 11:55 PM

Using custom keymaps this "panel" disappears, but is still functional ...
in fact if I want to change some settings, first I have to go back to the default keymaps so that I change the settings that interest me and then I put back the custom keymaps ...
My question is, couldn't a more elegant solution be found to remedy this situation?

William Reynish (billreynish) requested changes to this revision.Jan 23 2020, 3:02 PM

Is there a good reason why you made the whole Preferences window wider?

If it were not for that, I would accept this - it's a small but ok change.

This revision now requires changes to proceed.Jan 23 2020, 3:02 PM
Yevgeny Makarov (jenkm) updated this revision to Diff 21090.EditedJan 23 2020, 3:18 PM
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)

Is there a good reason why you made the whole Preferences window wider?

For aesthetic reasons only, the current one looks like an old 4x3, more "widescreen" looks more pleasant.

D6670 Make the Preferences window wider.

William Reynish (billreynish) added a comment.Jan 23 2020, 3:22 PM

I see. Well, it's debatable, and a wider window has implications of how the different sections look by default. IMO that is a separate issue from the layout of the keymap preferences.

Yevgeny Makarov (jenkm) added a comment.Feb 3 2020, 9:06 PM
This comment was removed by Yevgeny Makarov (jenkm).
Yevgeny Makarov (jenkm) updated this revision to Diff 21459.Feb 6 2020, 2:00 PM
Yevgeny Makarov (jenkm) retitled this revision from UI: Rearrange Keymap Preferences to UI: Tweak the Preferences Layout.
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)
Yevgeny Makarov (jenkm) added a project: User Interface.
Yevgeny Makarov (jenkm) updated this revision to Diff 21487.Feb 7 2020, 1:06 PM
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)

Update to reflect latest changes in keymap Preferences.

Yevgeny Makarov (jenkm) updated this revision to Diff 22207.Mar 1 2020, 1:18 PM
Yevgeny Makarov (jenkm) retitled this revision from UI: Tweak the Preferences Layout to UI: Rearrange Keymap Preferences.
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)
Yevgeny Makarov (jenkm) removed a subscriber: noki paike (amonpaike).

split into separate small patches

William Reynish (billreynish) accepted this revision.Mar 1 2020, 9:47 PM

LGTM

This revision is now accepted and ready to land.Mar 1 2020, 9:47 PM
Closed by commit rBbada2dcafd98: UI: improve layout of keymap preferences, more consistent with other areas (authored by Yevgeny Makarov (jenkm), committed by Brecht Van Lommel (brecht)). · Explain WhyMar 9 2020, 5:14 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rBbada2dcafd98: UI: improve layout of keymap preferences, more consistent with other areas.

Revision Contents
Changeset List

PathSize
release/
scripts/
modules/
3 lines
presets/
keyconfig/
44 lines
source/
blender/
editors/
screen/
2 lines

Diff 20866

View Options

release/scripts/modules/rna_keymap_ui.py

Loading...
View Options

release/scripts/presets/keyconfig/blender.py

Loading...
View Options

source/blender/editors/screen/screen_ops.c

Loading...