Page MenuHome
Differential D65

Fix T37670: Paint mode + procedural map colours error
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Dec 2 2013, 10:46 AM.

Details

Reviewers
Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)
Maniphest Tasks
T37670: Paint mode + procedural map colours error
Commits
rBSd3f3fb89cc2f: Fix T37670: Paint mode + procedural map colours error
rBd3f3fb89cc2f: Fix T37670: Paint mode + procedural map colours error
Summary

Seems to be known TODO in the code, but no idea why it
was never solved, especially since tweak is so much easy.

It might be arguable that we need to support painting
color space, but it's still much better to convert to
sRGB space. It's gonna to cover 90% of cases anyway.

Diff Detail

Branch
proj_paint_colorspace

Event Timeline

Sergey Sharybin (sergey) updated this revision to Unknown Object (????).Dec 2 2013, 12:37 PM

And for sure previous patch wasn't correct

multitex() doesn't ensure TexRes is in linear space,
so need to do extra checks in paint code.

Brecht Van Lommel (brecht) requested changes to this revision.Dec 2 2013, 3:10 PM

2D painting still has the same problem, so perhaps this isn't the right level to fix this problem? If this checking of imbuf rect_float is needed, that could at least be moved to some kind of utility function, that returns if sampling the texture will return linear or srgb colors.

Sergey Sharybin (sergey) updated this revision to Unknown Object (????).Dec 3 2013, 10:33 AM

Both 2d and projeciton painting works fine now.

Brecht Van Lommel (brecht) accepted this revision.Dec 3 2013, 3:31 PM

This looks good to me, except for float painting in 2D. Accepting revision assuming you agree with the fix there.

source/blender/editors/sculpt_paint/paint_image_2d.c
278 ↗(On Diff #195)

This should check with if(!use_float) so this conversion does not happen when painting on linear float images.

367 ↗(On Diff #195)

Same here.

Sergey Sharybin (sergey) closed this revision.Dec 3 2013, 5:13 PM

Added missing checks and landed the change. Thanks for the review!

Troy Sobotka (sobotka) mentioned this in T47212: Luminance Matte Node Fix.Jan 23 2016, 8:00 PM
Lukas Stockner (lukasstockner97) mentioned this in D1973: Cycles: Use proper XYZ <-> Scene Linear conversion instead of assuming sRGB.May 10 2016, 11:28 PM
Troy Sobotka (sobotka) mentioned this in T52311: Filmic Looks "None" and "Base contrast" do the same.Aug 9 2017, 11:40 PM
Troy Sobotka (sobotka) mentioned this in T84819: OpenColorIO 2.0 Upgrade.Feb 8 2021, 3:09 PM
Brecht Van Lommel (brecht) mentioned this in rBeb20250d2a51: Fix wrong white point of Linear ACES in config reading and the bundled config.Mar 10 2021, 4:57 PM
Vartan (Rey4eel) mentioned this in T87857: wrong image resolution (dpi) reported for certain jpg files from Photoshop.Apr 27 2021, 12:06 PM
Stefan Werner (swerner) mentioned this in rCad4b6c40f1fa: Fix wrong white point of Linear ACES in config reading and the bundled config.Jun 2 2021, 9:17 PM
David (Accelero) mentioned this in T68926: Color Management Improvements.Nov 26 2021, 5:10 AM
David (Accelero) mentioned this in T95368: Color Management: Linear ACES uses wrong white point adaptation .Jan 31 2022, 6:44 PM
Brecht Van Lommel (brecht) mentioned this in rBda6b534274d8: Fix T95368: wrong white point adaptation for Linear ACES color space.Feb 17 2022, 7:52 PM
Zijun Zhou (Eary) mentioned this in T96049: OCIO Aliases Feature Not Fully Working.Feb 26 2022, 10:07 PM
Evan Wilson (EAW) mentioned this in D14989: Python API: add mathutils.Color functions to convert color spaces.May 20 2022, 12:33 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sculpt_paint/
2 lines

Diff 172

View Options

source/blender/editors/sculpt_paint/paint_image_proj.c

Loading...