Page MenuHome
Differential D6602

Fix T73064: Embree does not like Bevel shader
ClosedPublic
Actions

Authored by Stefan Werner (swerner) on Jan 16 2020, 3:24 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Lukas Stockner (lukasstockner97)
Sergey Sharybin (sergey)
Commits
rC4d28fc9c9031: Fix T73064: Embree does not like Bevel shader
rB6257cdc376af: Fix T73064: Embree does not like Bevel shader
Summary

Embree's local intersection routine was not prepared
for local intersections without per-object BVH.
Now it should be able to handle any kind of local
intersection, such as AO, bevel and SSS.

Diff Detail

Repository
rB Blender

Event Timeline

Stefan Werner (swerner) created this revision.Jan 16 2020, 3:24 PM
Harbormaster completed remote builds in B6276: Diff 20889.Jan 16 2020, 3:24 PM
Stefan Werner (swerner) added reviewers: Brecht Van Lommel (brecht), Lukas Stockner (lukasstockner97), Sergey Sharybin (sergey).Jan 16 2020, 3:25 PM
Stefan Werner (swerner) added a project: Cycles.
Stefan Werner (swerner) added a subscriber: Cycles.
Stefan Werner (swerner) added a comment.Jan 16 2020, 3:36 PM

Or should I just go ahead and check in this without review, since it's a bug fix for Embree which is turned off by default anyway?

Brecht Van Lommel (brecht) added a comment.Jan 16 2020, 3:57 PM

You can just go ahead and commit.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 16 2020, 8:53 PM
Closed by commit rB6257cdc376af: Fix T73064: Embree does not like Bevel shader (authored by Stefan Werner (swerner)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Stefan Werner (swerner) added a commit: rB6257cdc376af: Fix T73064: Embree does not like Bevel shader.
Brecht Van Lommel (brecht) added a commit: rC4d28fc9c9031: Fix T73064: Embree does not like Bevel shader.Jan 31 2020, 6:29 PM

Revision Contents
Changeset List

PathSize
intern/
cycles/
bvh/
36 lines
kernel/
bvh/
36 lines
24 lines

Diff 20907

View Options

intern/cycles/bvh/bvh_embree.cpp

Loading...
View Options

intern/cycles/kernel/bvh/bvh.h

Loading...
View Options

intern/cycles/kernel/bvh/bvh_embree.h

Loading...