UI gizmo dial: Draw arc only over one rotation to avoid visual artifacts
AbandonedPublic
Actions

Authored by David Friedli (hlorus) on Jan 16 2020, 5:56 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Julian Eisel (Severin)

Summary

Currently when using the spin gizmo for a rotation greater than 360 degrees there can be some visual artifacts. This patch avoids this by drawing the arc over the span of one rotation only and adjusting the background color based on the rotation count.

before:

after:

Diff Detail

Repository

rB Blender

Branch

gizmo_dial3d_glitch (branched from master)

Build Status

Buildable 6297
Build 6297: arc lint + arc unit

Event Timeline

David Friedli (hlorus) created this revision.Jan 16 2020, 5:56 PM

Harbormaster completed remote builds in B6281: Diff 20894.Jan 16 2020, 5:57 PM

David Friedli (hlorus) edited the summary of this revision. (Show Details)Jan 16 2020, 6:04 PM

David Friedli (hlorus) added a reviewer: Campbell Barton (campbellbarton).

David Friedli (hlorus) added a project: User Interface.

William Reynish (billreynish) awarded a token.Jan 16 2020, 6:06 PM

Almost ready! Great find.

I did notice one small issue though, it's pretty weird: When you drag towards the blue (or red or green) circle, as opposed to dragging away from it, there is a flickering after the first full rotation:

If we don't find the cause of this we can probably still accept the patch - it's a minor issue. Would still be nice have fixed though.

Would also be good to add a comment to the code explaining what you are doing, it's not easy to understand just from the code.

This revision now requires changes to proceed.Jan 16 2020, 7:24 PM

-Address mentioned issue
-Add some comments
-Rebase

Harbormaster completed remote builds in B6297: Diff 20917.Jan 17 2020, 7:08 AM

@Julian Eisel (Severin) Thanks alot for the review!

In D6604#155356, @Julian Eisel (Severin) wrote:

Almost ready! Great find.

I did notice one small issue though, it's pretty weird: When you drag towards the blue (or red or green) circle, as opposed to dragging away from it, there is a flickering after the first full rotation:

The remaining arc wasn't correctly calculated for the negative range which caused the arcs to overlap, that's why there were some color differences.
Unfortunately the fix doesn't make it simpler either, i hope the comments help enough.

stefano severi (Tetone) awarded a token.Jan 17 2020, 7:35 AM

Looks good to me.

Campbell Barton (campbellbarton) awarded a token.Jan 17 2020, 9:22 AM