Page MenuHome
Differential D6620

Added tests for Deform modifiers
ClosedPublic
Actions

Authored by Himanshi Kalra (calra) on Jan 18 2020, 5:31 PM.

Details

Reviewers
Habib Gahbiche (zazizizou)
Howard Trickey (howardt)
Summary

Adds tests for the "Deform" modifiers based on the new test framework. The following tests for some default and some non-default parameters.

  • Shrink Wrap
  • Simple Deform
  • Smooth
  • Laplacian Smooth

The updated modifiers.blend file located lib/tests/modeling is attached:

modifiers.blend13 MBDownload

Diff Detail

Event Timeline

Himanshi Kalra (calra) created this revision.Jan 18 2020, 5:31 PM
Habib Gahbiche (zazizizou) added a comment.Jan 18 2020, 8:37 PM

Thanks for the patch. It looks good to me except for minor styling issues.

Style: comments start with capital letter and end with a full stop, Also keep consistent with the commenting style of the file (see inline comments)
For future patches, try to keep the mesh sizes as small as possible. We want our tests to run as quickly as possible.

tests/python/modifiers.py
134

Style: simply write

# Mesh deform modifier requires user input, so skip.

154

Such block comments should reflect what you can see in the blend file as text, e.g. 'List of Deform Modifiers' or 'One Generate Modifiers'

Habib Gahbiche (zazizizou) requested changes to this revision.Jan 18 2020, 8:38 PM
This revision now requires changes to proceed.Jan 18 2020, 8:38 PM
Himanshi Kalra (calra) updated this revision to Diff 20974.Jan 18 2020, 9:21 PM

Updated according to the suggestions made. Mostly the commenting style.

Himanshi Kalra (calra) updated this revision to Diff 20975.Jan 18 2020, 9:24 PM
Himanshi Kalra (calra) marked 2 inline comments as done.
Habib Gahbiche (zazizizou) accepted this revision.Jan 19 2020, 2:53 PM

I think it's better to first merge D6576 though since it has larger changes.

This revision is now accepted and ready to land.Jan 19 2020, 2:53 PM
Himanshi Kalra (calra) added a comment.Feb 4 2020, 3:37 AM

@Habib Gahbiche (zazizizou) Since D6576 is merged, do I have to update my blend file ?

Habib Gahbiche (zazizizou) added a comment.Feb 9 2020, 12:02 PM
In D6620#159431, @Himanshi Kalra (calra) wrote:

@Habib Gahbiche (zazizizou) Since D6576 is merged, do I have to update my blend file ?

yes please :)

Himanshi Kalra (calra) edited the summary of this revision. (Show Details)Feb 11 2020, 6:15 AM

@Habib Gahbiche (zazizizou) I have updated the blend file.

Himanshi Kalra (calra) updated this revision to Diff 22188.Feb 29 2020, 5:25 AM
Himanshi Kalra (calra) added a reviewer: Howard Trickey (howardt).

The diff is same, I have pulled the other changes to remove merge conflicts. The blend file is already updated to the best of my knowledge.

Himanshi Kalra (calra) updated this revision to Diff 22190.Feb 29 2020, 5:30 AM
Howard Trickey (howardt) mentioned this in rB22a8a3b21497: Apply patch D6620, Adde tests for Deform modifiers..Feb 29 2020, 8:07 PM
Howard Trickey (howardt) accepted this revision.Feb 29 2020, 8:10 PM

This is fine. I just submitted this patch with rB22a8a3b2149.

Howard Trickey (howardt) mentioned this in rBL62388: Update modifiers.blend for patch D6620, just applied..Feb 29 2020, 8:14 PM
Himanshi Kalra (calra) closed this revision.May 26 2020, 11:24 PM

Revision Contents
Changeset List

PathSize
tests/
python/
41 lines

Diff 20962

View Options

tests/python/modifiers.py

Loading...