Details

Reviewers

Summary

Description

This differential implements the function BKE_gpencil_stroke_perimeter_from_view and an operator (GPENCIL_OT_stroke_to_perimeter) that uses it.
The BKE function returns a bGPDstroke representing the points on the perimeter of the given stroke.

Demo

Here is an example of what the operator does:

This function does not handle clipping.

Issues

The algorithm does not take the line_change stroke thickness adjustment in the layer settings into account.
Running the operator on multiple strokes at once freezes blender.
Code needs to be refactored to be rebased onto greasepencil-refactor
F6 menu does not pop up
Parent-relation transformations are not handled correctly
End caps don't have the right thickness when manually scaled
Inner miter on corners does not take the thickness of the previous and next points into account

Performance

These tests were done on a ThinkPad E580 running Ubuntu 18.04.3 LTS.

We can clearly see the O(n) runtime of the algorithm.

Diff Detail

Repository

rB Blender

Branch

gpencil_stroke_to_perimeter

Build Status

Buildable 6334
Build 6334: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) created this revision.Jan 20 2020, 5:13 PM

Harbormaster completed remote builds in B6334: Diff 21010.Jan 20 2020, 5:13 PM

Falk David (filedescriptor) retitled this revision from GPencil: Add empty operator stroke_to_perimeter for testing to GPencil: Stroke to perimeter.Jan 20 2020, 5:16 PM

Falk David (filedescriptor) edited the summary of this revision. (Show Details)

Published a wrong diff

Falk David (filedescriptor) edited the summary of this revision. (Show Details)Jan 20 2020, 6:35 PM

Falk David (filedescriptor) added a reviewer: Antonio Vazquez (antoniov).Jan 20 2020, 6:39 PM

Falk David (filedescriptor) added a project: Grease Pencil.

Falk David (filedescriptor) added a subscriber: Falk David (filedescriptor).

Antonio Vazquez (antoniov) added inline comments.Jan 20 2020, 7:06 PM

source/blender/editors/gpencil/gpencil_edit.c
4765	Maybe it would be easy to use if you pass rv3d only and get the matrixs from that inside the function.

Falk David (filedescriptor) edited the summary of this revision. (Show Details)Jan 20 2020, 7:51 PM

Falk David (filedescriptor) added inline comments.

source/blender/editors/gpencil/gpencil_edit.c
4765	Yes, I had it like this before. My reasoning behind it was that if you want to project from a specific angle (e.g. onto x-y plane), you have that option. But if this is not needed, I can change it back

Falk David (filedescriptor) retitled this revision from GPencil: Stroke to perimeter to WIP GPencil: Stroke to perimeter.Jan 21 2020, 8:05 AM

Falk David (filedescriptor) edited the summary of this revision. (Show Details)

Make layer thickness adjustment affect stroke radius

Harbormaster completed remote builds in B6343: Diff 21023.Jan 21 2020, 9:19 AM

Falk David (filedescriptor) edited the summary of this revision. (Show Details)Jan 21 2020, 9:34 AM

Falk David (filedescriptor) edited the summary of this revision. (Show Details)

Charlie Jolly (charlie) awarded a token.Jan 21 2020, 11:17 AM

Fixed a bug where blender would freeze due to an infinite loop in the operator.

Falk David (filedescriptor) edited the summary of this revision. (Show Details)Jan 25 2020, 1:36 PM

Falk David (filedescriptor) edited the summary of this revision. (Show Details)Jan 25 2020, 2:14 PM

Falk David (filedescriptor) edited the summary of this revision. (Show Details)

Matias Mendiola (mendio) added a subscriber: Matias Mendiola (mendio).Jan 25 2020, 4:53 PM

Rebased branch onto greasepencil-refactor and implemented rounded corners

Falk David (filedescriptor) edited the summary of this revision. (Show Details)Jan 27 2020, 5:02 PM

Code refactor

Falk David (filedescriptor) edited the summary of this revision. (Show Details)Feb 3 2020, 4:14 PM

Falk David (filedescriptor) updated this revision to Diff 21363.Feb 3 2020, 7:27 PM

Fixed a merge issue, where a change did not propagate.

Fixed a bug where at a 180 deg angle a loop would appear inside the perimeter
Fixed a bug in the poll function that would result in the operator menu not showing up
Fixed a couple of compiler-warnings

Added the function BKE_gpencil_perimeter_stroke_get that creates a stroke perimeter from any given stroke.

Bun ny (bunny) awarded a token.Mar 20 2020, 10:00 AM

Falk David (filedescriptor) edited the summary of this revision. (Show Details)Mar 20 2020, 12:23 PM

Falk David (filedescriptor) edited the summary of this revision. (Show Details)Apr 24 2020, 5:48 PM

Moved main BKE to gpencil_geom.c and fixed the parent transform issue by introducing a new function: BKE_gpencil_stroke_to_view_space. This function handles the transformation to parent as well as view space. A lot of the code has also been simplified and cleaned up.

Falk David (filedescriptor) edited the summary of this revision. (Show Details)Apr 24 2020, 7:53 PM

Fixed an issue where the number of perimeter points was not counted correctly. Fixed an issue where the order of points on rounded corners was incorrect.

This patch will be part of the SVG export.

WIP GPencil: Stroke to perimeterAbandonedPublicActions

Details

Description

Demo

Issues

Performance

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21010

build_files/build_environment/CMakeLists.txt

build_files/build_environment/cmake/alembic.cmake

build_files/build_environment/cmake/boost.cmake

build_files/build_environment/cmake/harvest.cmake

build_files/build_environment/cmake/ilmbase.cmake

build_files/build_environment/cmake/openexr.cmake

build_files/build_environment/cmake/openimageio.cmake

build_files/build_environment/cmake/openvdb.cmake

build_files/build_environment/cmake/osl.cmake

build_files/build_environment/cmake/versions.cmake

build_files/build_environment/dependencies.dot

build_files/build_environment/install_deps.sh

build_files/build_environment/patches/blosc.diff

build_files/build_environment/patches/openvdb.diff

build_files/build_environment/windows/build_deps.cmd

extern/gflags/README.blender

extern/gflags/src/gflags/gflags_declare.h

extern/mantaflow/CMakeLists.txt

intern/cycles/render/background.h

intern/cycles/render/background.cpp

intern/cycles/render/light.cpp

intern/cycles/render/osl.cpp

intern/cycles/render/shader.cpp

intern/cycles/render/svm.cpp

intern/mantaflow/extern/manta_fluid_API.h

intern/mantaflow/intern/MANTA_main.h

intern/mantaflow/intern/MANTA_main.cpp

intern/mantaflow/intern/manta_fluid_API.cpp

intern/mantaflow/intern/strings/fluid_script.h

intern/mantaflow/intern/strings/liquid_script.h

intern/mantaflow/intern/strings/smoke_script.h

intern/openvdb/CMakeLists.txt

release/darwin/bundle.sh

release/freedesktop/org.blender.Blender.appdata.xml

release/scripts/startup/bl_ui/properties_physics_fluid.py

source/blender/alembic/intern/abc_exporter.cc

source/blender/blenfont/intern/blf.c

source/blender/blenkernel/BKE_gpencil.h

source/blender/blenkernel/BKE_lightprobe.h

source/blender/blenkernel/intern/armature.c

source/blender/blenkernel/intern/dynamicpaint.c

source/blender/blenkernel/intern/fluid.c

source/blender/blenkernel/intern/gpencil.c

source/blender/blenkernel/intern/lightprobe.c

source/blender/blenkernel/intern/particle_system.c

source/blender/collada/MeshImporter.cpp

source/blender/draw/engines/eevee/eevee_lightcache.c

source/blender/draw/engines/eevee/shaders/lit_surface_frag.glsl

source/blender/draw/engines/overlay/overlay_extra.c

source/blender/editors/gpencil/gpencil_edit.c

source/blender/editors/gpencil/gpencil_intern.h

source/blender/editors/gpencil/gpencil_ops.c

source/blender/editors/interface/interface_templates.c

source/blender/editors/mesh/editmesh_bevel.c

source/blender/editors/mesh/editmesh_bisect.c

source/blender/editors/mesh/editmesh_tools.c

source/blender/editors/object/object_add.c

source/blender/editors/sculpt_paint/sculpt.c

source/blender/editors/sculpt_paint/sculpt_undo.c

source/blender/editors/sculpt_paint/sculpt_uv.c

source/blender/editors/space_file/fsmenu.c

source/blender/makesdna/DNA_particle_types.h

source/blender/makesrna/intern/rna_fluid.c

source/blender/makesrna/intern/rna_main_api.c

source/blender/makesrna/intern/rna_particle.c

WIP GPencil: Stroke to perimeter
AbandonedPublic
Actions

Revision Contents
Changeset List