Page MenuHome

glTF importer: keep going if invalid custom property seen
AbandonedPublic

Authored by Gary Oberbrunner (garyo123) on Jan 21 2020, 9:15 PM.

Details

Summary

Some glTFs may have unusual data in "extras" -- the spec places no limits on what goes in there. But Blender doesn't like anything except ints, floats, and simple dicts. Currently, when such an invalid data item is found, the import fails with a TypeError. This patch just prints an error to the console with the name of the invalid property and keeps going.

Diff Detail

Event Timeline

Hi Julien, I believe you authored this file; would you mind reviewing? It's my first patch to Blender.

Hello,
Can you please open a PR in the upstream project: https://github.com/KhronosGroup/glTF-Blender-IO ?

This fix is now merge from upstream (here: 71ac0b888beb), so don't need to keep this ticket open