deps:Fix unwanted exports from libxml
ClosedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on Jan 21 2020, 10:53 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Commits

rB8c509f98e129: Build_environment: Fix unwanted exports from libxml on windows.

Summary

libxml puts dllexport on all its functions causing the
blender binary to export these symbols.

this diff fixes this unwanted behaviour.

D6645 and D6563 fixed similar issues.

didn't include all of the platform devs since a rebuild for other platforms
is not required.

Diff Detail

Repository

rB Blender

Branch

tmp_libxml (branched from master)

Build Status

Buildable 6351
Build 6351: arc lint + arc unit

Event Timeline

Ray Molenkamp (LazyDodo) created this revision.Jan 21 2020, 10:53 PM

Harbormaster completed remote builds in B6351: Diff 21046.Jan 21 2020, 10:54 PM

Ray Molenkamp (LazyDodo) mentioned this in D6647: Fix: oidn exporting its symbols in blender..Jan 21 2020, 11:20 PM

Brecht Van Lommel (brecht) accepted this revision.Jan 22 2020, 9:51 AM

This revision is now accepted and ready to land.Jan 22 2020, 9:51 AM

Think it's fine.

Can't currently test in a real environment since doing a lot of re-compilations for own patch already. So fingers crossed! :)

Closed by commit rB8c509f98e129: Build_environment: Fix unwanted exports from libxml on windows. (authored by Ray Molenkamp (LazyDodo)). · Explain WhyFeb 8 2020, 11:07 PM

This revision was automatically updated to reflect the committed changes.

Ray Molenkamp (LazyDodo) added a commit: rB8c509f98e129: Build_environment: Fix unwanted exports from libxml on windows..

Ray Molenkamp (LazyDodo) mentioned this in rBL62367: Windows: Fixed libxml.Feb 8 2020, 11:20 PM

Ray Molenkamp (LazyDodo) mentioned this in T74262: Cycles render hangs on Linux and AMD Radeon RX 5700 XT.Apr 5 2020, 9:46 PM

Revision Contents
Changeset List

Path

Size

build_files/

build_environment/

patches/

opencollada.diff

11 lines

Diff 21046

View Options

build_files/build_environment/patches/opencollada.diff

deps:Fix unwanted exports from libxmlClosedPublicActions