build_files/build_environment/patches/openimagedenoise.diff
130	Dunno, depends a bit on how clean of a ship we'd want to run, symbol visibility on gcc for the longest time was EXPORT ALL THE THINGS! and it still is unless you pass `-fvisibility=hidden` `#nm -D ./blender \| grep " T " \| wc -l 84291` seems to indicate that symbol visibility is not something we have looked at in the past on linux.

Sergey Sharybin (sergey) accepted this revision.Jan 22 2020, 4:07 PM

Sergey Sharybin (sergey) added inline comments.

build_files/build_environment/patches/openimagedenoise.diff
130	Seems to indicate that symbol visibility is not something we have looked at in the past on Linux. That is correct. Just a bit weird we start addressing it on Windows but not on Linux. But can do it when Linux time have time to make sure everything works. No need to hold Windows changes. Was just curious, you know ;)

I have to admit, i never bothered to check on windows either until i recently needed to check if NvOptimusEnablement was still being exported and couldn't easily spot it in the list of 35k symbol exports that had no business being exported.

hence the cleanup :)

Closed by commit rB6a1414dc5848: Build_environment: Fix unwanted exports from oidn on windows. (authored by Ray Molenkamp (LazyDodo)). · Explain WhyFeb 8 2020, 11:32 PM

This revision was automatically updated to reflect the committed changes.

Ray Molenkamp (LazyDodo) added a commit: rB6a1414dc5848: Build_environment: Fix unwanted exports from oidn on windows..

Ray Molenkamp (LazyDodo) mentioned this in rBL62368: Windows: Fixed OpenImageDenoise.

Ray Molenkamp (LazyDodo) mentioned this in T74262: Cycles render hangs on Linux and AMD Radeon RX 5700 XT.Apr 5 2020, 9:46 PM