Page MenuHome

device_cpu.cpp code cleanup
AbandonedPublic

Authored by Martijn Berger (juicyfruit) on Jul 21 2014, 9:09 AM.

Diff Detail

Event Timeline

lopata (lopataasdf) retitled this revision from to device_cpu.cpp code cleanup.
lopata (lopataasdf) updated this object.

I forgot to replace "kernel_cpu_shader" -> "shader_function" :(

You can submit a new diff, and after upload you can attach it to this revision, instead of creating a new revision. :)

You can click on "Submit Code" on the frontage (developer.blender.org), then upload the diff there and press "Create diff". In the next step you select this revision here from the drop down menu. ;) That's what I meant.

lopata (lopataasdf) edited edge metadata.

Generally the idea is fine. But do you mind updating the patch so it applies on top of current master? Would help a lot committing it.

Sergey Sharybin (sergey) requested changes to this revision.Jul 31 2014, 9:39 AM
Sergey Sharybin (sergey) edited edge metadata.
This revision now requires changes to proceed.Jul 31 2014, 9:39 AM
lopata (lopataasdf) edited edge metadata.

I created a path, but I now have no possibility to compile for checking

This is such a good idea that I took it from D808 which seems to have taken it from you. Sorry for not noticing this when committing.

Inadvertently committed without knowing it originated here