Changes to internal icons interpolation algorithm
ClosedPublic
Actions

Authored by Yevgeny Makarov (jenkm) on Jan 23 2020, 8:54 PM.

Details

Reviewers

Clément Foucault (fclem)
Julian Eisel (Severin)
Brecht Van Lommel (brecht)

Commits

rB5536be2cfe77: UI: better preserve icon sharpness at different UI scales

Summary

Changes to internal icons interpolation algorithm.

This patch changes the GL_TEXTURE_MIN_FILTER parameter from GL_LINEAR_MIPMAP_LINEAR to GL_LINEAR_MIPMAP_NEAREST.
It gives a sharper result, since with these settings only down scaling is used.

Also, these changes are necessary for D5655 (Support for custom icon sheets).

Comparison LINEAR (top) vs NEAREST (bottom) at a scale of 1.4x:

Various scales, new NEAREST on the left, old LINEAR on the right:

mipmap-filter-comparison.png299 KBDownload

Diff Detail

Repository: rB Blender

Event Timeline

Yevgeny Makarov (jenkm) created this revision.Jan 23 2020, 8:54 PM

Looks better to me. Implementation is also fine.

This revision is now accepted and ready to land.Jan 23 2020, 9:01 PM

Yevgeny Makarov (jenkm) added a reviewer: Brecht Van Lommel (brecht).Jan 28 2020, 2:24 PM

We used to have something like this, but seems it got lost in the OpenGL refactor.
rBec85a4370f1a: UI DPI: use a sharper filter when scaling icons, when the scale matches a…

I agree it's better to bias for sharpness.

Closed by commit rB5536be2cfe77: UI: better preserve icon sharpness at different UI scales (authored by Yevgeny Makarov (jenkm), committed by Brecht Van Lommel (brecht)). · Explain WhyJan 28 2020, 2:44 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB5536be2cfe77: UI: better preserve icon sharpness at different UI scales.

Yevgeny Makarov (jenkm) mentioned this in D5655: Support for custom interface icons.Jan 28 2020, 4:27 PM

Yevgeny Makarov (jenkm) mentioned this in D6859: UI: Larger Alert Icons.Feb 15 2020, 4:54 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

interface/

interface_icons.c

59 lines

Diff 21095

View Options

source/blender/editors/interface/interface_icons.c

Changes to internal icons interpolation algorithmClosedPublicActions