Credits go to a coworker (he wanted to be referred to as "prutser") who was importing some camera animations, just wanted it to work, but not create a Blender account ;(.
After this patch FocusDistance is applied to the Blender camera.
Details
Details
Diff Detail
Diff Detail
- Repository
- rBA Blender Add-ons
Event Timeline
Comment Actions
Thank you for assigning the right person. I saw that he's owning 'Data, Assets & I/O'. As a first submit I still wasn't sure I was supposed to assign this add-on diff to someone directly.
Comment Actions
That's fine, we don't expect you to know everything from the get-go. Congratulations on sending in your first patch :)
Comment Actions
Patch looks good, except for the issues of scale regarding that new value, mentioned in comments below.
| io_scene_fbx/import_fbx.py | ||
|---|---|---|
| 644 | According to doc (http://download.autodesk.com/us/fbx/SDKdocs/FBX_SDK_Help/files/fbxsdkref/class_k_fbx_camera.html) this value is in millimeters, so I think we need v / 1000 * global_scale here? | |
| 1527 | Style (space around operators). And as above, according to doc (http://download.autodesk.com/us/fbx/SDKdocs/FBX_SDK_Help/files/fbxsdkref/class_k_fbx_camera.html) this value is in millimeters, so I think we need elem_props_get_number(fbx_props, b'FocusDistance', 10 * 1000) / 1000 * global_scale here as well? | |
Comment Actions
Thanks, LGTM now, will commit.
| io_scene_fbx/import_fbx.py | ||
|---|---|---|
| 1565 | No reason to only read this when DoF is enabled? Will move it out of that check. | |