Page MenuHome

Fix T66505: Deleting the last keyframe in Grease Pencil Dope Sheet will leave the channel visible
AbandonedPublic

Authored by Philipp Oeser (lichtwerk) on Jan 24 2020, 3:36 PM.

Details

Summary

This will cause problems with e.g. "View All".

If we are deleting a GP layer channel, then the whole GP layer is
removed, same now happens when removing the last keyframe.

Diff Detail

Repository
rB Blender
Branch
T66505 (branched from master)
Build Status
Buildable 6378
Build 6378: arc lint + arc unit

Event Timeline

Delete all frames never must remove the layer itself. You can have empty layer to be used later.

Philipp Oeser (lichtwerk) planned changes to this revision.Jan 24 2020, 4:32 PM

OK, will see how to do it in another way...

Delete all frames never must remove the layer itself. You can have empty layer to be used later.

note again though that deleting the channel in the dopesheet already removes the layer as well... should that also be reconsidered as"wrong"?

No, if you delete a channel means you don't want the layer, so remove the layer is ok here. Only if you remove frames is when the layer must not delete because you maybe clear all frames to start drawing again in the layer.

No, if you delete a channel means you don't want the layer, so remove the layer is ok here. Only if you remove frames is when the layer must not delete because you maybe clear all frames to start drawing again in the layer.

I think this is a bit inconsistent (since we are in an animation editor), so why would deleting an entire animation channel have different results then deleting all of its keyframes?
Suggest to continue discussion in T66505 for now... (just dont think it would be good to have an empty channel show at all - might introduce unnecessary complexity to the dopesheet code...)