Page MenuHome
Differential D6678

Add Object Tool (WIP)
AbandonedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Jan 27 2020, 2:12 AM.
Tags
Subscribers
Chris Kohl (ckohl_art)
Duarte Farrajota Ramos (duarteframos)
Francesco Sorrentino (zeirus)
Konstantina Anagnostou (Constantina32)
Leul Mulugeta (Leul)
Pieter Schiettecatte (Schiette)
Tokens
"Burninate" token, awarded by Dir-Surya."Love" token, awarded by LeoSch."Love" token, awarded by Schamph."Love" token, awarded by Schiette."Love" token, awarded by jfmatheu."Love" token, awarded by franMarz."Love" token, awarded by Leul."Love" token, awarded by amonpaike."Love" token, awarded by billreynish.

Details

Reviewers
None
Maniphest Tasks
T57210: Add Object Tools Todo
Summary

This is a work in progress patch for T57210: Add Object Tools Todo, this isn't ready for review yet.

What works:

  • Interactively adding primitives with two clicks.
  • Scene orientation used for new objects.
  • Position enum [ view-plane / axis-plane / surface ]
  • Origin enum [ base / center ]
  • Primitive object types [ cube / cylinder / cone / uv-sphere / ico-sphere ]
  • Settings for object types in the top-bar.
  • Constrain 1:1 aspect (Shift).
  • Toggle center (Alt).
  • Snapping (Ctrl).
  • Handle "Error" cases (when the cursor-plane intersection is behind the view for example).

TODO:

  • Add "Cone" icon.
  • Show a preview plane before adding the object.
  • Gizmos to adjust the dimensions after adding the object.

Diff Detail

Repository
rB Blender
Branch
TEMP-OBJECT-ADD (branched from master)
Build Status
Buildable 8248
Build 8248: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) created this revision.Jan 27 2020, 2:12 AM
Harbormaster completed remote builds in B6390: Diff 21150.Jan 27 2020, 2:12 AM
Campbell Barton (campbellbarton) retitled this revision from Add Object Tool (WIP patch) to Add Object Tool (WIP).Jan 27 2020, 2:17 AM
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)
Campbell Barton (campbellbarton) added a project: BF Blender.
Campbell Barton (campbellbarton) added a task: T57210: Add Object Tools Todo.
Campbell Barton (campbellbarton) updated this revision to Diff 21152.Jan 27 2020, 2:27 AM

Remove some unused code

Harbormaster completed remote builds in B6391: Diff 21152.Jan 27 2020, 2:28 AM
William Reynish (billreynish) awarded a token.Jan 27 2020, 9:01 AM
Konstantina Anagnostou (Constantina32) added a subscriber: Konstantina Anagnostou (Constantina32).Jan 27 2020, 12:30 PM
Germano Cavalcante (mano-wii) mentioned this in T69576: location and rotation with align to 3d cursor .Jan 27 2020, 7:53 PM
Duarte Farrajota Ramos (duarteframos) added a subscriber: Duarte Farrajota Ramos (duarteframos).Jan 28 2020, 12:02 AM
noki paike (amonpaike) awarded a token.Jan 28 2020, 3:32 PM
Francesco Sorrentino (zeirus) added a subscriber: Francesco Sorrentino (zeirus).Feb 7 2020, 11:48 AM
Campbell Barton (campbellbarton) updated this revision to Diff 21489.EditedFeb 7 2020, 1:23 PM

Update:

  • Add position [view-plane / axis-plane / surface].
  • Origin [base / center].
  • Use scene orientation setting for object rotation.
  • Add object types [cube / cylinder / cone / uv-sphere / ico-sphere ]
  • Expose settings object type settings in the top-bar.
Harbormaster completed remote builds in B6526: Diff 21489.Feb 7 2020, 1:23 PM
Campbell Barton (campbellbarton) updated this revision to Diff 21490.Feb 7 2020, 1:26 PM

Sync with master

Harbormaster completed remote builds in B6527: Diff 21490.Feb 7 2020, 1:27 PM
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Feb 7 2020, 1:38 PM
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)
Campbell Barton (campbellbarton) updated this revision to Diff 21492.EditedFeb 7 2020, 1:57 PM
  • Remove redundant headers
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Feb 7 2020, 1:58 PM
Harbormaster completed remote builds in B6528: Diff 21492.Feb 7 2020, 2:02 PM
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Feb 7 2020, 2:20 PM
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Feb 7 2020, 3:11 PM
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Feb 10 2020, 5:03 AM
Leul Mulugeta (Leul) awarded a token.Feb 10 2020, 11:02 AM
Campbell Barton (campbellbarton) mentioned this in T73874: Tools don't have a way to snap to geometry before they're activated (knife).Feb 17 2020, 7:54 AM
Fran Marz (franMarz) awarded a token.Feb 19 2020, 5:08 AM
Campbell Barton (campbellbarton) updated this revision to Diff 21989.Feb 24 2020, 3:00 AM
  • Add modal keymap, fix aspect option
  • Modifier keys to toggle center & fixed aspect ratio
Harbormaster completed remote builds in B6733: Diff 21989.Feb 24 2020, 3:00 AM
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Feb 24 2020, 3:12 AM
Germano Cavalcante (mano-wii) mentioned this in D6927: Transform Snap: Clear 'SnapObjectData' after changes in the geometry.Feb 25 2020, 5:50 PM
Chris Kohl (ckohl_art) added a subscriber: Chris Kohl (ckohl_art).Feb 29 2020, 9:16 PM
Connor McCampbell (realeyez) added a subscriber: Connor McCampbell (realeyez).Mar 5 2020, 7:40 AM
Campbell Barton (campbellbarton) updated this revision to Diff 25092.EditedMay 26 2020, 8:29 AM
  • When X-ray is disabled, draw in two passes, so it's possible to tell which lines are behind existing objects without obscuring the lines completely.
  • Use gizmo color.
  • Use thick line shader.
  • Rebase on master.
Harbormaster completed remote builds in B8209: Diff 25092.May 26 2020, 8:29 AM
Campbell Barton (campbellbarton) updated this revision to Diff 25094.May 26 2020, 8:35 AM

Remove unused headers.

Harbormaster completed remote builds in B8210: Diff 25094.May 26 2020, 8:35 AM
Campbell Barton (campbellbarton) updated this revision to Diff 25096.May 26 2020, 10:44 AM
  • Add snapping support
  • Cleanup, move to 3D view, remove commented code
Harbormaster completed remote builds in B8211: Diff 25096.May 26 2020, 10:44 AM
Campbell Barton (campbellbarton) updated this revision to Diff 25097.May 26 2020, 10:48 AM
  • Rename keymap function
Harbormaster completed remote builds in B8212: Diff 25097.May 26 2020, 10:48 AM
Campbell Barton (campbellbarton) updated this revision to Diff 25100.May 26 2020, 11:05 AM
  • Add missing doc-strings, tweak UI spacing
Harbormaster completed remote builds in B8214: Diff 25100.May 26 2020, 11:05 AM
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)May 26 2020, 11:05 AM
Campbell Barton (campbellbarton) updated this revision to Diff 25103.May 26 2020, 1:28 PM
  • Move add tools out of edit-mesh
Harbormaster completed remote builds in B8216: Diff 25103.May 26 2020, 1:28 PM
Campbell Barton (campbellbarton) updated this revision to Diff 25104.May 26 2020, 1:43 PM
  • Add descriptions for placement enum items
Harbormaster completed remote builds in B8217: Diff 25104.May 26 2020, 1:43 PM
Campbell Barton (campbellbarton) updated this revision to Diff 25105.May 26 2020, 2:28 PM
  • Use fallback when the projected point is behind the view
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)May 26 2020, 2:28 PM
Harbormaster completed remote builds in B8218: Diff 25105.May 26 2020, 2:28 PM
Campbell Barton (campbellbarton) updated this revision to Diff 25106.May 26 2020, 2:45 PM
  • Fix center object toggle
Harbormaster completed remote builds in B8219: Diff 25106.May 26 2020, 2:45 PM
Campbell Barton (campbellbarton) updated this revision to Diff 25109.May 26 2020, 3:01 PM
  • Rename keymap
Harbormaster completed remote builds in B8221: Diff 25109.May 26 2020, 3:01 PM
Juanfran Matheu (jfmatheu) awarded a token.May 26 2020, 7:57 PM
Pieter Schiettecatte (Schiette) awarded a token.May 26 2020, 11:00 PM
Pieter Schiettecatte (Schiette) added a subscriber: Pieter Schiettecatte (Schiette).
Silas Opel (Schamph) awarded a token.May 26 2020, 11:16 PM
Leul Mulugeta (Leul) added a subscriber: Leul Mulugeta (Leul).May 27 2020, 12:49 AM
Campbell Barton (campbellbarton) updated this revision to Diff 25148.May 27 2020, 8:33 AM

Correct UI

Harbormaster completed remote builds in B8240: Diff 25148.May 27 2020, 8:33 AM
Leo Schmidt (LeoSch) awarded a token.May 27 2020, 1:32 PM
Campbell Barton (campbellbarton) updated this revision to Diff 25162.May 27 2020, 3:06 PM
  • Use plane as fallback for surface
Harbormaster completed remote builds in B8248: Diff 25162.May 27 2020, 3:06 PM
Campbell Barton (campbellbarton) updated this revision to Diff 25182.May 28 2020, 6:18 AM

Support running the operator directly (not as a tool)

Harbormaster completed remote builds in B8258: Diff 25182.May 28 2020, 6:18 AM
Campbell Barton (campbellbarton) updated this revision to Diff 25183.May 28 2020, 6:25 AM

Expose hide_keymap to RNA API

Harbormaster completed remote builds in B8259: Diff 25183.May 28 2020, 6:25 AM
Campbell Barton (campbellbarton) abandoned this revision.May 28 2020, 7:18 AM

Committed rB122cb1aea823: Object: new add object tool, currently for primitive types

Connor McCampbell (realeyez) removed a subscriber: Connor McCampbell (realeyez).May 29 2020, 3:10 AM
surya kiran reddy (Dir-Surya) awarded a token.Jun 1 2020, 11:30 AM

Revision Contents
Changeset List

PathSize
release/
scripts/
presets/
keyconfig/
keymap_data/
35 lines
startup/
bl_ui/
142 lines
source/
blender/
editors/
curve/
2 lines
gizmo_library/
gizmo_types/
41 lines
include/
5 lines
1 line
mesh/
113 lines
object/
64 lines
2 lines
space_view3d/
2 lines
2 lines
203 lines
6 lines
3 lines
1067 lines

Diff 25162

View Options

release/scripts/presets/keyconfig/keymap_data/blender_default.py

Loading...
View Options

release/scripts/startup/bl_ui/space_toolsystem_toolbar.py

Loading...
View Options

source/blender/editors/curve/editcurve_add.c

Loading...
View Options

source/blender/editors/gizmo_library/gizmo_types/snap3d_gizmo.c

Loading...
View Options

source/blender/editors/include/ED_gizmo_library.h

Loading...
View Options

source/blender/editors/include/ED_object.h

Loading...
View Options

source/blender/editors/mesh/editmesh_add.c

Loading...
View Options

source/blender/editors/object/object_add.c

Loading...
View Options

source/blender/editors/object/object_volume.c

Loading...
View Options

source/blender/editors/space_view3d/CMakeLists.txt

Loading...
View Options

source/blender/editors/space_view3d/space_view3d.c

Loading...
View Options

source/blender/editors/space_view3d/view3d_gizmo_placement.c

Loading...
View Options

source/blender/editors/space_view3d/view3d_intern.h

Loading...
View Options

source/blender/editors/space_view3d/view3d_ops.c

Loading...
View Options

source/blender/editors/space_view3d/view3d_placement.c

Loading...