Page MenuHome
Differential D6704

Fix T73469: OSL: Vector Math Node modulo uses wrong function
ClosedPublic
Actions

Authored by Charlie Jolly (charlie) on Jan 28 2020, 11:23 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rC6a24b9573f79: Fix T73469: OSL: Vector Math Node modulo uses wrong function
rBd3670823b377: Fix T73469: OSL: Vector Math Node modulo uses wrong function

Diff Detail

Repository
rB Blender

Event Timeline

Charlie Jolly (charlie) created this revision.Jan 28 2020, 11:23 PM
Harbormaster completed remote builds in B6424: Diff 21235.Jan 28 2020, 11:25 PM
Charlie Jolly (charlie) mentioned this in T73469: OSL: Vector Math Node modulo uses wrong function.Jan 28 2020, 11:29 PM
Charlie Jolly (charlie) added a comment.Jan 28 2020, 11:33 PM

For comparison node_math.osl uses safe_modulo as a wrapper around the OSL fmod function but according to OSL docs, fmod should be safe.

Brecht Van Lommel (brecht) accepted this revision.Jan 29 2020, 9:26 AM
This revision is now accepted and ready to land.Jan 29 2020, 9:26 AM
Charlie Jolly (charlie) updated this revision to Diff 21249.EditedJan 29 2020, 1:19 PM

@Brecht Van Lommel (brecht) I discovered during testing that GLSL c_mod for negative values is inconsistent too. Updated patch with compatible function to match OSL/Cycles fmod.

Harbormaster completed remote builds in B6430: Diff 21249.Jan 29 2020, 1:19 PM
Charlie Jolly (charlie) requested review of this revision.Jan 29 2020, 1:20 PM
Brecht Van Lommel (brecht) accepted this revision.Jan 29 2020, 1:34 PM
This revision is now accepted and ready to land.Jan 29 2020, 1:34 PM
Closed by commit rBd3670823b377: Fix T73469: OSL: Vector Math Node modulo uses wrong function (authored by Charlie Jolly (charlie)). · Explain WhyJan 29 2020, 1:38 PM
This revision was automatically updated to reflect the committed changes.
Charlie Jolly (charlie) added a commit: rBd3670823b377: Fix T73469: OSL: Vector Math Node modulo uses wrong function.
Brecht Van Lommel (brecht) added a commit: rC6a24b9573f79: Fix T73469: OSL: Vector Math Node modulo uses wrong function.Jun 2 2020, 7:32 AM

Revision Contents
Changeset List

PathSize
intern/
cycles/
kernel/
shaders/
2 lines
source/
blender/
gpu/
shaders/
material/
2 lines
11 lines
2 lines

Diff 21252

View Options

intern/cycles/kernel/shaders/node_vector_math.osl

Loading...
View Options

source/blender/gpu/shaders/material/gpu_shader_material_math.glsl

Loading...
View Options

source/blender/gpu/shaders/material/gpu_shader_material_math_util.glsl

Loading...
View Options

source/blender/gpu/shaders/material/gpu_shader_material_vector_math.glsl

Loading...