Page MenuHome
Differential D6710

Fix T64024 Red line on menu bar in fullscreen (macOS)
ClosedPublic
Actions

Authored by Yevgeny Makarov (jenkm) on Jan 29 2020, 2:21 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T64024: Red Line on menu bar (Mac OS)
Commits
rB57801426792c: Fix T64024: fullscreen switching on macOS shows red line artifacts
Summary

Fix T64024 Red line on menu bar in fullscreen (macOS).

To reproduce the bug:

  • turn on the "Automatically hide and show the menu bar"
  • turn on the "Automatically hide and show the Dock"
  • maximize (zoom) the Blender windows
  • and then switch to fullscreen mode

In this case, when switching from "maximized" to "fullscreen" the GHOST_kEventWindowSize not triggered.

There are a bunch of tasks merged to T64024.
I'm not sure any of them will be fixed by this patch either.

Diff Detail

Repository
rB Blender

Event Timeline

Yevgeny Makarov (jenkm) created this revision.Jan 29 2020, 2:21 PM
Stas (girafic) added a subscriber: Stas (girafic).Jan 30 2020, 9:39 AM

Tested with the build 2.83 Alpha, works fine on OSX Catalina 10.15.3.

Yevgeny Makarov (jenkm) added a comment.Jan 30 2020, 11:59 AM

@Stas (girafic) Do you mean it works without this patch?

Stas (girafic) added a comment.Jan 31 2020, 9:56 AM
In D6710#158745, @Yevgeny Makarov (jenkm) wrote:

@Stas (girafic) Do you mean it works without this patch?

No, it works only with this patch.

Yevgeny Makarov (jenkm) added a comment.Jan 31 2020, 3:21 PM

No, it works only with this patch.

Thank you, I just thought maybe some changes in OSX Catalina 10.15.3.

Brecht Van Lommel (brecht) accepted this revision.Jan 31 2020, 6:41 PM

Thanks a lot for finding this.

This revision is now accepted and ready to land.Jan 31 2020, 6:41 PM
Closed by commit rB57801426792c: Fix T64024: fullscreen switching on macOS shows red line artifacts (authored by Yevgeny Makarov (jenkm), committed by Brecht Van Lommel (brecht)). · Explain WhyJan 31 2020, 6:43 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB57801426792c: Fix T64024: fullscreen switching on macOS shows red line artifacts.
Yevgeny Makarov (jenkm) added a comment.EditedFeb 5 2020, 5:52 PM

@Brecht Van Lommel (brecht)

I found a case where these changes would lead to crash.

Open child windows (eg View Render), make it full-screen, and try closing it.

The problem is with [(NSWindow *)associatedWindow->getOSWindow() isZoomed], without it works.

  • When you close the fullscreen window, it closes first and then the windowDidExitFullScreen event is sent, which causes the crash.
  • This doesn't quite work for child windows, there is still a "red background" glitch when switching to the fullscreen mode.
  • The animation/transition when switching from "maximized" to "fullscreen" mode is not as smooth as from "normal" to "fullscreen".
Yevgeny Makarov (jenkm) reopened this revision.Feb 6 2020, 7:14 PM
Yevgeny Makarov (jenkm) mentioned this in T73616: Temporary windows with "New Window" mode are not updated correctly in full-screen.
This revision is now accepted and ready to land.Feb 6 2020, 7:15 PM
Yevgeny Makarov (jenkm) requested review of this revision.Feb 6 2020, 7:16 PM
Yevgeny Makarov (jenkm) planned changes to this revision.Feb 10 2020, 9:27 AM
Yevgeny Makarov (jenkm) updated this revision to Diff 21599.Feb 11 2020, 1:42 PM

This version works quite well, in my testing, sometimes artifacts appear, especially when Ctrl-Cmd-F are used, (when you keep holding F), it looks like a lag in the event system or something.

I also added WindowSize event to windowDidChangeBackingProperties, I can't test it, but I guess it might solve the similar problem with connecting/disconnecting an external monitor (changing resolutions).

Brecht Van Lommel (brecht) accepted this revision.EditedFeb 11 2020, 2:05 PM

@Yevgeny Makarov (jenkm), do you want commit rights to commit accepted patches yourself?

This revision is now accepted and ready to land.Feb 11 2020, 2:05 PM
Yevgeny Makarov (jenkm) updated this revision to Diff 21602.Feb 11 2020, 2:10 PM
Yevgeny Makarov (jenkm) added a comment.Feb 11 2020, 2:19 PM

Do you want commit rights to commit accepted patches yourself?

I think not, it's difficult for me, I can break something :)

Brecht Van Lommel (brecht) added a comment.Feb 11 2020, 2:21 PM

Ok, that's fine, I'll commit.

Brecht Van Lommel (brecht) closed this revision.Feb 11 2020, 3:40 PM

Committed in rBbf361fc9a00c: Fix T64024: monitor/fullscreen switching on macOS shows red line artifacts.

Revision Contents
Changeset List

PathSize
intern/
ghost/
intern/
6 lines

Diff 21255

View Options

intern/ghost/intern/GHOST_WindowCocoa.mm

Loading...