Fix wrong array size check in clang array checker
ClosedPublic
Actions

Authored by Simon G. (intrigus) on Jan 29 2020, 10:36 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)

Commits

rB370a6175e093: Fix wrong glColor3usv array size check in clang array checker

Summary

Check for glColor4usv was added twice, first checking for 3 arguments.
This check was then overwritten by a check that checks for 4 arguments.
This should probably have been a check for glColor3usv instead.

Diff Detail

Repository: rB Blender

Event Timeline

Simon G. (intrigus) created this revision.Jan 29 2020, 10:36 PM

Brecht Van Lommel (brecht) accepted this revision.Feb 4 2020, 5:51 PM

This revision is now accepted and ready to land.Feb 4 2020, 5:51 PM

Closed by commit rB370a6175e093: Fix wrong glColor3usv array size check in clang array checker (authored by Simon G <intrigus>, committed by Brecht Van Lommel (brecht)). · Explain WhyFeb 4 2020, 5:55 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB370a6175e093: Fix wrong glColor3usv array size check in clang array checker.

Revision Contents
Changeset List

Path

Size

build_files/

cmake/

clang_array_check.py

2 lines

Diff 21271

View Options

build_files/cmake/clang_array_check.py

Fix wrong array size check in clang array checkerClosedPublicActions