Fix T73095: Edit Mode Overlay Linked Mesh
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Feb 3 2020, 8:28 AM.

Details

Reviewers

Clément Foucault (fclem)
Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)

Maniphest Tasks

T72733: Issue with shared meshes overwriting modifiers
T73095: [Edit Mesh] overlay of linked meshes in Edit Mode. [2.82 regression]

Commits

rBd09646a40b19: Fix T73095: Edit Mode Overlay Linked Mesh

Summary

When having one part of a duplicate linked object in edit mode the other
part didn't draw in edit mode. This used to be the case in b2.79-b2.81.

There are multiple related tickets that changed this part of the code to
reflect how it used to work.

The current change introduces a draw manager method that checks in detail who is responsible for the drawing (render engine or overlay engine).
If the edit mesh is not the original or the object that is drawn doesn't draw the original mesh the object will be drawn by the render engine.

Known Limitation of this patch is that the rendering outside edit mode doesn't reflect the latest changes until the user switches between object and edit mode.
When there are no modifiers in use, the updating is done immediately (no surface batches are used).

IMO this would be sufficient for blender 2.82, it also fixes T72733. The updating of the surface batches requires more development.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Feb 3 2020, 8:28 AM

Harbormaster completed remote builds in B6468: Diff 21345.Feb 3 2020, 8:28 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Feb 3 2020, 8:31 AM

Jeroen Bakker (jbakker) added reviewers: Clément Foucault (fclem), Campbell Barton (campbellbarton).

Jeroen Bakker (jbakker) added projects: GPU / Viewport, Modeling.

Quick reply here as blender.chat connection is timing out on my end for some reason.

The issue with this is having an edit-mesh for a mesh doesn't mean the depsgraph generated run-time data will be up to date,
I manged create situations with two windows with different collections sharing the same mesh which would crash if it assumed having edit-mesh meant having edit-mesh display data.

Tested this patch I managed to crash switching between scenes which had two different objects sharing the object data. although I'm not sure thats related to T72848: Multiple windows displaying an linked duplicate, crashes when transforming in edit-mode.