Page MenuHome
Differential D6753

Fix T73226: Add defaults and versioning for uv_relax_method
AbandonedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Feb 5 2020, 12:15 AM.

Details

Reviewers
Jeroen Bakker (jbakker)
Maniphest Tasks
T73226: UV Relaxation Method is not set
Summary

This should fix the issue of previouly saved and new files.

Diff Detail

Repository
rB Blender
Branch
T73226 (branched from master)
Build Status
Buildable 6496
Build 6496: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Feb 5 2020, 12:15 AM
Harbormaster completed remote builds in B6496: Diff 21407.Feb 5 2020, 12:15 AM
Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).Feb 7 2020, 9:09 AM
Jeroen Bakker (jbakker) requested changes to this revision.Feb 7 2020, 4:19 PM
Jeroen Bakker (jbakker) added inline comments.
source/blender/blenloader/intern/versioning_280.c
4423

Wouldn't this reset the option everytime you load a file?
You can bump the subversion and check on the subversion so this doesn't happen.

This revision now requires changes to proceed.Feb 7 2020, 4:19 PM
Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).Mar 5 2020, 4:05 AM
Aaron Carlisle (Blendify) added inline comments.
source/blender/blenloader/intern/versioning_280.c
4423

This is in the section for *Versioning code until next subversion bump goes here.* So if I understand this is correct and will be fine by release when all this code gets put under an if (!MAIN_VERSION_ATLEAST(bmain, ***, *))

Pablo Dobarro (pablodp606) updated this revision to Diff 24743.May 14 2020, 3:00 AM

-Rebase

Is this versioning code correct as it is now or do I need to bump the subversion?

Harbormaster completed remote builds in B8038: Diff 24743.May 14 2020, 3:00 AM
Pablo Dobarro (pablodp606) updated this revision to Diff 24744.May 14 2020, 3:03 AM
  • Fix git marker
Harbormaster completed remote builds in B8039: Diff 24744.May 14 2020, 3:03 AM
Jeroen Bakker (jbakker) requested changes to this revision.May 14 2020, 3:48 PM

Without the versioning bump the setting will be reset every time the user opens a file. We should increase the sub version so that users can save and load their file with the correct settings.

This revision now requires changes to proceed.May 14 2020, 3:48 PM
Pratik Borhade (PratikPB2123) mentioned this in T96250: Pressing autocomplete in the console after tool_settings prints warning message.Mar 9 2022, 6:28 AM
Pratik Borhade (PratikPB2123) abandoned this revision.Mar 9 2022, 6:30 AM
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).

Fixed by rB136f0910ff66: Fix T96250: Invalid default for uv_relax_method

Revision Contents
Changeset List

PathSize
source/
blender/
blenloader/
intern/
6 lines
makesdna/
2 lines

Diff 21407

View Options

source/blender/blenloader/intern/versioning_280.c

Loading...
View Options

source/blender/makesdna/DNA_scene_defaults.h

Loading...