Paths

Table of Contentst

Differential D6755

UI: Reports when saving a file
ClosedPublic
Actions

Authored by Yevgeny Makarov (jenkm) on Feb 5 2020, 2:05 PM.

Tags

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)

Maniphest Tasks

T71493: No Info in status bar when saving file from the menu (as opposed to using the hotkey)

Summary

UI: Reports when saving a file.

T71493 No info in status bar when saving file from the menu
https://devtalk.blender.org/t/locked-files-problems/8887

Now the behaviors are consistent for blend, image and text files:

If the file is not writable, will report it.
If the file is new (without a path), save as will be used.
If the file was deleted, will try to recreate it.

Diff Detail

Repository: rB Blender

Event Timeline

Yevgeny Makarov (jenkm) created this revision.Feb 5 2020, 2:05 PM

Yevgeny Makarov (jenkm) added a task: T71493: No Info in status bar when saving file from the menu (as opposed to using the hotkey).Feb 5 2020, 2:07 PM

This seems fine but I need to test it still.

source/blender/editors/space_image/image_ops.c
2273	Either remove this code, or leave a comment about why it is disabled.

Yevgeny Makarov (jenkm) updated this revision to Diff 21526.Feb 8 2020, 10:39 AM

Yevgeny Makarov (jenkm) marked an inline comment as done.

Dim the "Save" menu item if the file is not dirty or goes to "Save As", for some cases which are easy to check.

In D6755#160609, @Yevgeny Makarov (jenkm) wrote:

Dim the "Save" menu item if the file is not dirty or goes to "Save As", for some cases which are easy to check.

I don't see this in other applications, is that really a common convention?

To me it seems mostly inconvenient, I think Save in the menu and Ctrl + S should do exactly the same thing.

This revision now requires changes to proceed.Feb 10 2020, 3:15 PM

@Brecht Van Lommel (brecht) then just check the previous diff: https://developer.blender.org/D6755?id=21526

However, the "Save" in the menu and Ctrl + S do the same thing. The "Save" menu item just not set to active in .py to show the user that the file has already been saved (not dirty), for example. I think this is a common practice.

By the way, it is not very clear what the active and enabled options are for. The API docs says for enabled: "When false, this (sub)layout is grayed out", but it seems this way active works.

layout.active = False will gray out buttons inside a layout.
layout.enabled = False will gray out and completely disable the buttons inside a layout.

Reverted to version 21526.

Brecht Van Lommel (brecht) accepted this revision.Mar 9 2020, 5:24 PM

This revision is now accepted and ready to land.Mar 9 2020, 5:24 PM

Update to reflect current state of master (in image_ops.c > image_save_exec).

Fix capitalization "Saved Image %s" > "Saved image %s".

removed an already committed part rB1c5831144040709380e02fc41ddef2e10d998cda

'name' was renamed to 'filepath'

@Brecht Van Lommel (brecht) @Campbell Barton (campbellbarton) - is this still OK and may be committed?

Campbell Barton (campbellbarton) mentioned this in rBd26b746e3670: UI: use "Save As" when saving un-saved image/text files.Oct 29 2020, 11:12 AM

Thanks, committed rBd26b746e3670: UI: use "Save As" when saving un-saved image/text files

Campbell Barton (campbellbarton) closed this revision.Oct 29 2020, 11:35 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

interface/

interface_region_tooltip.c

2 lines

space_image/

65 lines

space_text/

51 lines

windowmanager/

intern/

10 lines

Diff 21526

source/blender/editors/interface/interface_region_tooltip.c

Loading...

source/blender/editors/space_image/image_ops.c

Loading...

source/blender/editors/space_text/text_ops.c

Loading...

source/blender/windowmanager/intern/wm_files.c

Loading...