Page MenuHome
Differential D6784

Fix T63787: Intersect Knife: Segmentation fault
AbandonedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Feb 8 2020, 4:32 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Group Reviewers
Modeling
Maniphest Tasks
T63787: Intersect Knife: Segmentation fault or incorrect behavior
Summary

I am not sure how the USE_DISSOLVE logic works and how it is involved
with the s.wire_edges, but I could see that USE_DISSOLVE doesn't work
well with USE_SPLICE since the vertices tagged to be dissolved were spliced.

Then the solution is to untag the vert to be dissolved when the other
(in USE_SPLICE) is not tagged.

Ref T63787

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 6544
Build 6544: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Feb 8 2020, 4:32 PM
Harbormaster completed remote builds in B6544: Diff 21529.Feb 8 2020, 4:32 PM
Germano Cavalcante (mano-wii) updated this revision to Diff 21559.Feb 9 2020, 11:35 PM
  • Improvement - vertices to dissolve are never removed in the splice context
Harbormaster completed remote builds in B6554: Diff 21559.Feb 9 2020, 11:35 PM
Dalai Felinto (dfelinto) added a project: BF Blender (2.83).Apr 9 2020, 1:47 PM
Germano Cavalcante (mano-wii) abandoned this revision.Apr 24 2020, 5:21 AM

Resolved by committing rBd428cca12426: Fix T63787: Knife intersect crashes

Revision Contents
Changeset List

PathSize
source/
blender/
bmesh/
tools/
8 lines

Diff 21529

View Options

source/blender/bmesh/tools/bmesh_intersect.c

Loading...