Page MenuHome
Differential D6787

Cleanup: Node degree --> Angle
Needs RevisionPublic
Actions

Authored by Aaron Carlisle (Blendify) on Feb 8 2020, 7:51 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Group Reviewers
Compositing
Maniphest Tasks
T53574: UI: Composting nodes Rotate socket rename
Summary

The Rotate composting node has a property that should be renamed from "Degr[ee]" to "Angle",
because it can also be in radians based on the scene settings.

Fixes T53574

Diff Detail

Event Timeline

Aaron Carlisle (Blendify) created this revision.Feb 8 2020, 7:51 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Feb 11 2020, 2:52 PM

Do existing files with a rotate node load correctly? I expect this needs some versioning code to convert them?

Jeroen Bakker (jbakker) requested changes to this revision.Feb 17 2020, 4:20 PM

D6787.blend588 KBDownload

Current file does not load correctly (there is a link between the Value node and the rotate node.

This revision now requires changes to proceed.Feb 17 2020, 4:20 PM
Hans Goudey (HooglyBoogly) mentioned this in D8842: UI: Use consistent "Brightness" term, fix T80127.Oct 17 2020, 2:26 AM
Yevgeny Makarov (jenkm) mentioned this in D4179: Fix T53574.Nov 2 2020, 11:55 AM

Revision Contents
Changeset List

PathSize
source/
blender/
compositor/
nodes/
4 lines
operations/
2 lines
14 lines
nodes/
composite/
nodes/
2 lines

Diff 21533

View Options

source/blender/compositor/nodes/COM_RotateNode.cpp

Loading...
View Options

source/blender/compositor/operations/COM_RotateOperation.h

Loading...
View Options

source/blender/compositor/operations/COM_RotateOperation.cpp

Loading...
View Options

source/blender/nodes/composite/nodes/node_composite_rotate.c

Loading...