Differential D6791
Theming colors and size of background (transparency) checkerboard pattern Authored by Michael Soluyanov (crantisz) on Feb 8 2020, 9:51 PM.
Details This patch adds ability to set up colors and size of background (transparency) checkerboard pattern in viewport and 2d editors. No new backgrounds, only changing colors in existing ones. This is not the background of the viewport, it is a transparency checkerboard that is turned on only in render mode, when the transparency mode is on. And also in 2D-editors, (image, sequencer, ets) Some examples:    How it works: Useful for bright themes:  Same in Krita: 
Diff Detail
Event TimelineComment Actions Hey @Michael Soluyanov (crantisz), I tried to contact you but it seems there is no direct message here, someone told me you're working on this patch so maybe you could merge this proposal which has already the code for it, it's just needs an update. Comment Actions Hello, you do not understand a bit. This is not the background of the viewport, it is a transparency checkerboard that is turned on only in render mode, when the transparency mode is on. And also in 2D-editors, (image, sequencer, ets) Comment Actions Avoid using different names and abbreviations in the user interface and implementation. Use either "transparent" or "alpha" for both.
Comment Actions While this patch was on review, Checkerboard was moved from EEVEE to Overlays, so I keep it in GlobalsUboStorage: colors are already here, added size only. Text formatting fixed. Comment Actions So what is needed to do in this case? Make this in different way? Looks like "alpha" is already used in code... But for UX, better "transparent". For example, Krita uses "transparent" and "Transparency settings" in Photoshop Comment Actions Whoever commits this can do the subversion bump, nothing needed from your side.
Comment Actions Accepting for the code side. We can commit this if he gives green light.
Comment Actions Pretty handy to have a setting like this! I would suggest changing the name of the properties. Calling color properties as "light" or "dark", when they can be altered to be the opposite (dark to be a light color and the other way around), can be confusing. I suggest calling such properties "primary" and "secondary", then you're not assuming what would be the color used for. Something like transparent_checker_primary, transparent_checker_secondary. Comment Actions Thanks for making the changes @Michael Soluyanov (crantisz)! Looks good for me now from the UI side, whenever you have the time to commit @Julian Eisel (Severin) :D | ||||||||||||||||||||||||||||||||||||||||||||||||