Fix T73656: Use BKE_brush_alpha_get in texture paint
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Feb 10 2020, 8:31 PM.

Details

Reviewers

Jeroen Bakker (jbakker)
Brecht Van Lommel (brecht)

Maniphest Tasks

T73656: Fill tool with unified strength checked not working as with unified strength unchecked

Commits

rB35490c3ead03: Fix T73656: Use BKE_brush_alpha_get in texture paint

Summary

The code was using brush->alpha directly, so the alpha value from
UnifiedPaintSettings was not used when eneabled.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Feb 10 2020, 8:31 PM

Harbormaster completed remote builds in B6565: Diff 21585.Feb 10 2020, 8:31 PM

Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).Feb 10 2020, 8:32 PM

For performance it's better to move this outside the loop, now that it's a more expensive function call.

Review update

Harbormaster completed remote builds in B6584: Diff 21620.Feb 11 2020, 5:25 PM

Brecht Van Lommel (brecht) accepted this revision.Feb 11 2020, 5:31 PM

This revision is now accepted and ready to land.Feb 11 2020, 5:31 PM

Closed by commit rB35490c3ead03: Fix T73656: Use BKE_brush_alpha_get in texture paint (authored by Pablo Dobarro (pablodp606)). · Explain WhyFeb 11 2020, 5:47 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rB35490c3ead03: Fix T73656: Use BKE_brush_alpha_get in texture paint.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

paint_image_2d.c

7 lines

paint_image_proj.c

6 lines

Diff 21623

View Options

source/blender/editors/sculpt_paint/paint_image_2d.c