Page MenuHome
Differential D6836

Fix T73774: Error in Paint 'Clone from Image/UV Map' panel
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Feb 13 2020, 3:22 PM.

Details

Reviewers
William Reynish (billreynish)
Julian Eisel (Severin)
Campbell Barton (campbellbarton)
Maniphest Tasks
T73774: Image Editor - AttributeError: 'NoneType' object has no attribute 'material_slots'
Commits
rBd9e4f5a7e8e9: Fix T73774: Error in Paint 'Clone from Image/UV Map' panel
Summary

This panel is not for 2D paint, IMAGEPAINT_PROJECT_LAYER_CLONE is only ever used in projection painting, not 2D painting.
Add a proper poll for this.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Feb 13 2020, 3:22 PM
Harbormaster completed remote builds in B6606: Diff 21688.Feb 13 2020, 3:22 PM
Julian Eisel (Severin) accepted this revision.Feb 14 2020, 1:19 AM
This revision is now accepted and ready to land.Feb 14 2020, 1:19 AM
Campbell Barton (campbellbarton) requested changes to this revision.EditedFeb 14 2020, 7:44 AM
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).

The object check should be restricted to settings.mode == 'MATERIAL' case, since this panel is also for 2D image painting.

This revision now requires changes to proceed.Feb 14 2020, 7:44 AM
Philipp Oeser (lichtwerk) added a comment.Feb 14 2020, 9:31 AM
In D6836#161963, @Campbell Barton (campbellbarton) wrote:

The object check should be restricted to settings.mode == 'MATERIAL' case, since this panel is also for 2D image painting.

settings.mode == 'IMAGE' also requires a mesh object...? or does this work without UVs? checking again...

Philipp Oeser (lichtwerk) added a comment.Feb 14 2020, 10:35 AM

In fact, after checking more, this whole panel is useless in 2D paint, IMAGEPAINT_PROJECT_LAYER_CLONE is only ever used in ... well projection painting, not 2D painting...
I mean, I guess it could be supported in 2D as well, but this is outside the scope of this fix.
Will update diff accordingly...

Campbell Barton (campbellbarton) added a comment.Feb 14 2020, 10:39 AM

In that case the PAINT_2D check should be removed.

Philipp Oeser (lichtwerk) updated this revision to Diff 21707.Feb 14 2020, 10:51 AM

remove panel from 2D paint entirely

Harbormaster completed remote builds in B6614: Diff 21707.Feb 14 2020, 10:51 AM
Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Feb 14 2020, 10:51 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 14 2020, 11:14 AM
Closed by commit rBd9e4f5a7e8e9: Fix T73774: Error in Paint 'Clone from Image/UV Map' panel (authored by Philipp Oeser (lichtwerk)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBd9e4f5a7e8e9: Fix T73774: Error in Paint 'Clone from Image/UV Map' panel.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
2 lines

Diff 21708

View Options

release/scripts/startup/bl_ui/properties_paint_common.py

Loading...