Page MenuHome
Differential D6838

UI: Allow gizmo-only redraw tagging
ClosedPublic
Actions

Authored by Julian Eisel (Severin) on Feb 13 2020, 4:35 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)
Commits
rBc4b9cb0af0ae: UI: Allow gizmo-only redraw tagging
Summary

We currently redraw the entire area whenever a gizmo needs redrawing, which would be nice to avoid in the future, see T73198. The first step towards this would be having a separate tag for them, which is what this patch implements.

NOTE: This change shouldn't have any visible effect. It's just the first (easiest) step towards decoupling gizmo redraws from viewport redraws.

Diff Detail

Repository
rB Blender

Event Timeline

Julian Eisel (Severin) created this revision.Feb 13 2020, 4:35 PM
Harbormaster completed remote builds in B6609: Diff 21691.Feb 13 2020, 4:35 PM
Julian Eisel (Severin) edited the summary of this revision. (Show Details)Feb 13 2020, 4:39 PM
stefano severi (Tetone) awarded a token.Feb 13 2020, 7:03 PM
Julian Eisel (Severin) added a comment.Feb 13 2020, 7:30 PM

Let me add: I chose the name ED_region_tag_redraw_editor_overlays() over ED_region_tag_redraw_gizmos() because due to the way we currently draw, we can not redraw-gizmos without also redrawing other editor overlays. Namely annotations which are drawn in-between 3D and 2D gizmos.

Brecht Van Lommel (brecht) accepted this revision.Feb 14 2020, 3:12 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).
Brecht Van Lommel (brecht) added inline comments.
source/blender/editors/include/ED_screen.h
75

This could be renamed to ED_region_tag_redraw_cursor since that's all it's doing. To avoid confusion with the new function.

This revision is now accepted and ready to land.Feb 14 2020, 3:12 PM
Closed by commit rBc4b9cb0af0ae: UI: Allow gizmo-only redraw tagging (authored by Julian Eisel (Severin)). · Explain WhyFeb 14 2020, 4:04 PM
This revision was automatically updated to reflect the committed changes.
Julian Eisel (Severin) added a commit: rBc4b9cb0af0ae: UI: Allow gizmo-only redraw tagging.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
gizmo_library/
gizmo_types/
2 lines
2 lines
2 lines
2 lines
include/
1 line
screen/
20 lines
space_view3d/
4 lines
4 lines
transform/
2 lines
2 lines
makesdna/
3 lines
windowmanager/
gizmo/
intern/
8 lines
6 lines
3 lines
2 lines

Diff 21724

View Options

source/blender/editors/gizmo_library/gizmo_types/arrow3d_gizmo.c

Loading...
View Options

source/blender/editors/gizmo_library/gizmo_types/cage2d_gizmo.c

Loading...
View Options

source/blender/editors/gizmo_library/gizmo_types/cage3d_gizmo.c

Loading...
View Options

source/blender/editors/gizmo_library/gizmo_types/move3d_gizmo.c

Loading...
View Options

source/blender/editors/include/ED_screen.h

Loading...
View Options

source/blender/editors/screen/area.c

Loading...
View Options

source/blender/editors/space_view3d/view3d_gizmo_preselect_type.c

Loading...
View Options

source/blender/editors/space_view3d/view3d_gizmo_ruler.c

Loading...
View Options

source/blender/editors/transform/transform_gizmo_2d.c

Loading...
View Options

source/blender/editors/transform/transform_gizmo_3d.c

Loading...
View Options

source/blender/makesdna/DNA_screen_types.h

Loading...
View Options

source/blender/windowmanager/gizmo/intern/wm_gizmo_group.c

Loading...
View Options

source/blender/windowmanager/gizmo/intern/wm_gizmo_map.c

Loading...
View Options

source/blender/windowmanager/gizmo/intern/wm_gizmo_target_props.c

Loading...
View Options

source/blender/windowmanager/gizmo/intern/wm_gizmo_type.c

Loading...