Paths

Table of Contentst

Differential D6849

Fix T68610: B-Bone display size/scaling op issues
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Feb 14 2020, 1:38 PM.

Tags

None

Subscribers

Brecht Van Lommel (brecht)

Details

Reviewers

Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)

Group Reviewers

Maniphest Tasks

T68610: B-Bone display size/scaling op issues

Commits

rBef4505a1583f: Fix T68610: B-Bone display size/scaling op issues

Summary

Fix redo and create a new operator to display only the required properties.
Keymap Changes.

Diff Detail

Repository

Branch

master

Build Status

Buildable 6618
Build 6618: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Feb 14 2020, 1:38 PM

Harbormaster completed remote builds in B6618: Diff 21714.Feb 14 2020, 1:38 PM

Germano Cavalcante (mano-wii) added a task: T68610: B-Bone display size/scaling op issues.Feb 14 2020, 1:41 PM

Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Feb 14 2020, 1:44 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/editors/transform/transform_ops.c
1024–1025	These names should be better, the name should always include a verb. ot->name = "Scale B-Bone"; ot->description = "Scale selected bendy bones display size"; `TRANSFORM_OT_bonesize` can also be renamed to match.

Improve description.
rename "bonesize" to "bbone_resize"

It would also be nice to rename the file "transform_mode_bonesize.c" to
"transform_mode_bbone_resize.c", but this could be for another commit.

Harbormaster completed remote builds in B6620: Diff 21718.Feb 14 2020, 3:08 PM

Missed

Harbormaster completed remote builds in B6621: Diff 21719.Feb 14 2020, 3:12 PM

Brecht Van Lommel (brecht) accepted this revision.Feb 14 2020, 3:38 PM

This revision is now accepted and ready to land.Feb 14 2020, 3:38 PM

Closed by commit rBef4505a1583f: Fix T68610: B-Bone display size/scaling op issues (authored by Germano Cavalcante (mano-wii)). · Explain WhyFeb 14 2020, 3:51 PM

This revision was automatically updated to reflect the committed changes.

Germano Cavalcante (mano-wii) added a commit: rBef4505a1583f: Fix T68610: B-Bone display size/scaling op issues.

Revision Contents
Changeset List

Path

Size

release/

scripts/

presets/

keyconfig/

keymap_data/

blender_default.py

6 lines

source/

blender/

editors/

transform/

transform_mode_bonesize.c

24 lines

transform_ops.c

27 lines

Diff 21714

release/scripts/presets/keyconfig/keymap_data/blender_default.py

Loading...

source/blender/editors/transform/transform_mode_bonesize.c

Loading...

source/blender/editors/transform/transform_ops.c

Loading...