Hey @Andrzej Ambroz (jendrzych) - The following is the SVG I was working on. Excuse the programmer art.

You should see that it is 5 256x256 icons for a total of 128x256. The first started as blown-up versions of your smaller icons, aligned to this grid, and borders added. The last one is taken directly from an SVG from the blender site.

When thinking about minimum feature sizes, I doubt these would ever be shown at less than about 64x64

@Campbell Barton (campbellbarton) - This patch makes changes to the "exit" dialog only as a way to show off the use of these icons. My hope is that we would NOT commit any changes to wm_files.c and leave that to further discussion. So, in a nutshell, don't worry too much about the changes to the dialog.

@Harley Acheson (harley)

const rcti crop = {xmin, xmax, ymin, ymax};
IMB_rect_crop(ibuf, &crop);

Can't we just do it the same way we handle the prvicons in the File Browser?

In D6859#162791, @William Reynish (billreynish) wrote:

Can't we just do it the same way we handle the prvicons in the File Browser?

The coloring part? Not really. The prvicons are very private to the File Browser and has better control over the lifecycle of those bitmaps. We need to worry not just about how they are created and used but also how and when they are disposed.

I suggest using one sheet with different sizes of each icon, 'crop' faster than 'scale', and it also allows you to use different design (detail) for different sizes.

• On a Mac, there should be a gap between the "Don't Save" button and the "Cancel", "Save".
• The icon is too large relative to the current text size.
• Title (without icon) and lines with an icon or checkbox are not aligned.
• The checkbox is too close to the large icon.

• You should scale the icons exactly in half, or you will not get perfectly clear lines.
• The icon in the screenshot above is 128 px (for retina), works good.

• Or use an icon sheet like the next one and you will always have perfect icons in any size.
• Although I don't think there is a need for a 256 icon, 128 is already very large on the retina screen.

@Andrzej Ambroz (jendrzych) The Inkscape leaves a lot of garbage in the SVG file, here is the cleaned file, 14kB vs 527kB.

@Yevgeny Makarov (jenkm)
I managed going down to 9kb. :)

I have an even smaller version :))
Only in this case (plain svg) you lose some settings such as layers.

Indeed, it would be good to get the changes in from @Yevgeny Makarov (jenkm)'s paintover.

In D6859#163687, @William Reynish (billreynish) wrote:

Indeed, it would be good to get the changes in from @Yevgeny Makarov (jenkm)'s paintover.

Yes, but this thread should really just be about the addition of the icons, rather than bikeshedding on the quit dialog. That dialog is only featured here as a way to show what the icons can look like in place.

I would prefer to commit the icons on their own and then make a separate patch for the quit dialog. Otherwise we won't get the icons in. I did change the icon padding to match his paintover, but things like that gap between "don't save" and "cancel" either needs someone to figure out how to do that or that is a feature that needs to be added to our layout logic.

Yes - things like the spacing between the buttons is unrelated to this. But the fact that the text is now not alignedned because the icons changed would ideally be fixed here, I think.

@William Reynish (billreynish) - But the fact that the text is now not alignedned because the icons changed would ideally be fixed here, I think.

No, that alignment issue is unrelated to adding large icons to the project.

We can't really change the formatting of the quit dialog until we get the large icons in there. But then you are asking to fix an unrelated formatting issue with the dialog before the images can go in.

So take the current code as it is RIGHT NOW, without this patch. The dialog shows the "title" with a single line like the following:

uiItemL(layout, title, ICON_ERROR);

Now just add a few variations below it, so it looks like this:

uiItemL(layout, title, ICON_ERROR);
uiItemL(layout, title, ICON_NONE);
uiItemL(layout, title, NULL);
uiItemL(layout, title, ICON_QUESTION);

You would expect these items, two with icons and two without, to line up vertically properly. But they do not:

Are saying that I have to hunt down this current behavior in layout before you would accept larger icons? I have no idea why these labels are set to behave as they do. I'll certainly look and see if I can fix this, and perhaps there is some cludge, but it is not introduced by the patch.

Do we need these icons regardless of the dialog box?
Seems like it's gonna be hard to fix all these alignment problems.
And so far, it looks worse than what we have right now.

By the way, just ten lines of code and I have this dialog box.
With bonuses like: displaying buttons on the Touch Bar, bold font for the title, word-wrap for long lines...

@Yevgeny Makarov (jenkm) - By the way, just ten lines of code and I have this dialog box.

Yes, I could probably make a Windows dialog with less lines than that as well. But we're not going to use OS-supplied dialogs any time soon.

But we're not going to use OS-supplied dialogs any time soon.

I know :)

I seem to know how to align the buttons, I'll try.

@Andrzej Ambroz (jendrzych) some work for you.

The size of the icons is 64x64 (128x128 for Retina), so you need to design them to be 64. Keep svg in 64 and just export it to 128 or 256.
The size of the symbol itself is 52x52, (for my taste).

Here are some templates that you can use, and preview.

@Yevgeny Makarov (jenkm) - ...you need to design them to be 64...export it to 128 or 256..size of the symbol itself is 52x52, (for my taste).
Here are some templates that you can use, and preview.

They are currently designed in a 64x64 grid with the symbols about 52x52, and exported at 128. Almost exactly what you ask for.

Here is the copy of the exported PNG with a background added and some rules to illustrate their sizes and placement:

They should be redrawn in 64px so that when they are scaled from 128 to 64 you get clear/sharp lines.

This is the current at 64px and to the right is what I expect to see.

Setting @Brecht Van Lommel (brecht) as reviewer, since he also recently reviewed many similar patches.

@Campbell Barton (campbellbarton) I hope that's ok with you - if not, feel free to say so.

@Harley Acheson (harley) you need IMB_premultiply_alpha before you IMB_scaleImBuf.