This is more an eye candy for Visual Studio developers.
It moves the extern_draco project in Visual Studio under the extern folder where it belongs according to the source tree.
It also makes it consistent on how libs are added in blender.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
| extern/draco/CMakeLists.txt | ||
|---|---|---|
| 47 | Duplicating code all over the place is not the way to go, In build_files/cmake/macros.cmake add a blender_project_group macro that has this bit of code in it and call the macro instead. Once you have the macro don't forget to de-duplicate the code in blender_add_lib__impl as well. | |
This comment was removed by Phillip Thomas (Cambloid).
Comment Actions
But now the function name no longer covers what it actually does since it sets both the source and project groups, which is the reason i suggested the separate macro.
I see the upside of not having to do 2 calls though, i'm torn here, @Brecht Van Lommel (brecht) any strong opinion between renaming blender_source_group to blender_source_and_project_groups (or something else) and keeping two separate macro's for the source and project groups?
| build_files/cmake/macros.cmake | ||
|---|---|---|
| 172 | whitespace changes | |