Cycles: Fix failing avxf cross test on AVX2
ClosedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on Feb 18 2020, 4:29 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Commits

rCcfeec12b1d8e: Fix failing avxf cross test on avx2
rB003a97e0bf50: Cycles: Fix failing avxf cross test on AVX2

Summary

cycles_util_avxf_avx2_test was failing on the cross test, since
it wasn't immediately clear why, the test was disabled.

After looking into it, this test when build for AVX2 is
generating FMA instructions where the intermediate results
have "infinite" precision [1] leading to slightly different
results,

This diff re-enables the cross test and allows for a small error
in the results.

[1] https://www.felixcloutier.com/x86/vfmadd132ps:vfmadd213ps:vfmadd231ps

Diff Detail

Repository: rB Blender

Event Timeline

Ray Molenkamp (LazyDodo) created this revision.Feb 18 2020, 4:29 AM

Harbormaster completed remote builds in B6658: Diff 21818.Feb 18 2020, 4:29 AM

Brecht Van Lommel (brecht) accepted this revision.Feb 18 2020, 9:12 AM

Brecht Van Lommel (brecht) added inline comments.

intern/cycles/test/util_avxf_test.h
49	Missing space after comma, need to run clang-format?

This revision is now accepted and ready to land.Feb 18 2020, 9:12 AM

clang-format

Harbormaster completed remote builds in B6666: Diff 21833.Feb 18 2020, 2:35 PM

Closed by commit rB003a97e0bf50: Cycles: Fix failing avxf cross test on AVX2 (authored by Ray Molenkamp (LazyDodo)). · Explain WhyFeb 18 2020, 2:53 PM

This revision was automatically updated to reflect the committed changes.

Ray Molenkamp (LazyDodo) added a commit: rB003a97e0bf50: Cycles: Fix failing avxf cross test on AVX2.

Brecht Van Lommel (brecht) added a commit: rCcfeec12b1d8e: Fix failing avxf cross test on avx2.Jun 2 2020, 7:36 AM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

test/

util_avxf_test.h

30 lines

Diff 21834

View Options

intern/cycles/test/util_avxf_test.h

Cycles: Fix failing avxf cross test on AVX2ClosedPublicActions