Fix T73859: Support executing sculpt.set_pivot_position without invoke
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Feb 18 2020, 2:31 PM.

Details

Reviewers

Matthias Pieroth (jayanam)
Brecht Van Lommel (brecht)

Maniphest Tasks

T73859: Python method Set Pivot to unmasked has no effect

Summary

Unfortunately, there is still a depsgraph related bug:

Go to sculpt mode in default file.
Search and run Set Pivot Position operator.
Run the operator a second time.
Go into the redo settings and change any parameter (to trigger a redo).
Crash.

It fails in BKE_sculpt_update_object_for_edit because the depsgraph is
not yet fully evaluated. I'm not sure how this should be fixed. Any hints
would be appreciated. (@Sergey Sharybin (sergey), @Brecht Van Lommel (brecht))

Diff Detail

Repository

rB Blender

Branch

use-exec-in-set-pivot-operator (branched from master)

Build Status

Buildable 6665
Build 6665: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Feb 18 2020, 2:31 PM

Harbormaster completed remote builds in B6665: Diff 21832.Feb 18 2020, 2:32 PM

Jacques Lucke (JacquesLucke) added a task: T73859: Python method Set Pivot to unmasked has no effect.Feb 18 2020, 2:33 PM

Use CTX_data_ensure_evaluated_depsgraph instead of CTX_data_depsgraph_pointer to solve that.

@Jacques Lucke (JacquesLucke) Can I do the review or is a special role required?

fix depsgraph handling

Harbormaster completed remote builds in B6667: Diff 21837.Feb 18 2020, 3:15 PM

@Brecht Van Lommel (brecht) thanks!

@Matthias Pieroth (jayanam) Yes, you can check if this fixes your issue.

Jacques Lucke (JacquesLucke) retitled this revision from Fix T73859: Support executing sculpt.set_pivot_position without invoke [WIP] to Fix T73859: Support executing sculpt.set_pivot_position without invoke.Feb 18 2020, 3:16 PM

Anyone is welcome to help reviewing, but for a patch to be really considered accepted for committing it should be done by someone with commit rights.

This revision is now accepted and ready to land.Feb 18 2020, 3:16 PM

In D6879#162938, @Brecht Van Lommel (brecht) wrote:

Anyone is welcome to help reviewing, but for a patch to be really considered accepted for committing it should be done by someone with commit rights.

Ok, I see, thx. Will apply the diff anyway to check if it works:-)

rBd54a4a32f386890c39a4d0b783b957a0619af3a5

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

sculpt.c

33 lines

Diff 21832

View Options

source/blender/editors/sculpt_paint/sculpt.c

Fix T73859: Support executing sculpt.set_pivot_position without invokeClosedPublicActions