Page MenuHome
Differential D6887

Fix T73938: Cycles Vertex Color wrong if no layer is specified
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Feb 19 2020, 9:57 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T73938: Cycles: Vertex Color shader node is not handled properly/ignored if no vertex color is specified (should use the 'active_render' then)
Commits
rCaaf5549c483e: Fix T73938: Cycles Vertex Color wrong if no layer is specified
rB65ea5020c4a1: Fix T73938: Cycles Vertex Color wrong if no layer is specified
Summary

The node would render black in this case (but should use the
'active_render' layer choosen in the object data properties -- this is
now in line to how this is handled for e.g. UVs)

This introduces ATTR_STD_VCOL and uses this thoughout, if no particular
layer is specified in the node.

Diff Detail

Repository
rB Blender
Branch
T73938 (branched from master)
Build Status
Buildable 6687
Build 6687: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Feb 19 2020, 9:57 AM
Harbormaster completed remote builds in B6683: Diff 21873.Feb 19 2020, 9:57 AM
Brecht Van Lommel (brecht) added a comment.Feb 19 2020, 10:10 AM

The general approach here seems fine. I don't think Cycles standalone needs updates for this. I'll wait for review until it's more complete.

intern/cycles/kernel/kernel_types.h
756

ATTR_STD_VCOL -> ATTR_STD_VERTEX_COLOR

Philipp Oeser (lichtwerk) updated this revision to Diff 21878.Feb 19 2020, 11:31 AM
  • ATTR_STD_VCOL -> ATTR_STD_VERTEX_COLOR
  • add OSL
Harbormaster completed remote builds in B6687: Diff 21878.Feb 19 2020, 11:31 AM
Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Feb 19 2020, 11:32 AM
Philipp Oeser (lichtwerk) marked an inline comment as done.
Brecht Van Lommel (brecht) accepted this revision.Feb 19 2020, 11:46 AM

Thanks!

This revision is now accepted and ready to land.Feb 19 2020, 11:46 AM
Closed by commit rB65ea5020c4a1: Fix T73938: Cycles Vertex Color wrong if no layer is specified (authored by Philipp Oeser (lichtwerk)). · Explain WhyFeb 19 2020, 12:16 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB65ea5020c4a1: Fix T73938: Cycles Vertex Color wrong if no layer is specified.
Brecht Van Lommel (brecht) added a commit: rCaaf5549c483e: Fix T73938: Cycles Vertex Color wrong if no layer is specified.Jun 2 2020, 7:37 AM

Revision Contents
Changeset List

PathSize
intern/
cycles/
blender/
42 lines
kernel/
1 line
shaders/
11 lines
render/
5 lines
28 lines

Diff 21878

View Options

intern/cycles/blender/blender_mesh.cpp

Loading...
View Options

intern/cycles/kernel/kernel_types.h

Loading...
View Options

intern/cycles/kernel/shaders/node_vertex_color.osl

Loading...
View Options

intern/cycles/render/attribute.cpp

Loading...
View Options

intern/cycles/render/nodes.cpp

Loading...