Page MenuHome

Cycles: Add option to change which sample to start viewport denoising at
ClosedPublic

Authored by Patrick Mours (pmoursnv) on Feb 21 2020, 2:15 PM.

Details

Summary

Viewport denoising currently starts right away, which can produce very weird results with a small start resolution. It would be better to only start denoising when it actually makes sense. But based on feedback in D6554 some prefer to have it start right away, I also got feedback that would prefer the opposite though.

To satisfy both views, this patch adds a new user-configurable option to change at which sample viewport denoising should kick in. Setting it to zero retains current behavior (start immediately), while other values will defer denoising until the particular sample has been reached. Default is now at 1, to avoid the weirdness that is AI denoising at small resolutions.

Diff Detail

Repository
rB Blender
Branch
cycles_denoising_start_sample (branched from master)
Build Status
Buildable 6720
Build 6720: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) added inline comments.
intern/cycles/blender/addon/ui.py
712

Can you gray this out when viewport denoising is disabled?

This revision is now accepted and ready to land.Feb 24 2020, 10:21 PM
Patrick Mours (pmoursnv) marked an inline comment as done.Feb 25 2020, 3:38 PM